{"id":707,"url":"https://patchwork.libcamera.org/api/1.1/patches/707/?format=json","web_url":"https://patchwork.libcamera.org/patch/707/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190306024755.28726-4-niklas.soderlund@ragnatech.se>","date":"2019-03-06T02:47:53","name":"[libcamera-devel,3/5] test: camera: Add setting of format test","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f5e7138d90801ccefe4f4f9da4bfa410b3c8b63b","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/707/mbox/","series":[{"id":203,"url":"https://patchwork.libcamera.org/api/1.1/series/203/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=203","date":"2019-03-06T02:47:50","name":"test: camera: Add basic tests for the camera","version":1,"mbox":"https://patchwork.libcamera.org/series/203/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/707/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/707/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE21D611A2\n\tfor ;\n\tWed, 6 Mar 2019 03:48:21 +0100 (CET)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 4cdb3461-3fba-11e9-985a-005056917f90;\n\tWed, 06 Mar 2019 03:48:20 +0100 (CET)"],"X-Halon-ID":"4cdb3461-3fba-11e9-985a-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 6 Mar 2019 03:47:53 +0100","Message-Id":"<20190306024755.28726-4-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190306024755.28726-1-niklas.soderlund@ragnatech.se>","References":"<20190306024755.28726-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/5] test: camera: Add setting of format\n\ttest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 06 Mar 2019 02:48:22 -0000"},"content":"Try to set the default format, a modified valid format and an invalid\nformat.\n\nSigned-off-by: Niklas Söderlund \n---\n test/camera/format_set.cpp | 88 ++++++++++++++++++++++++++++++++++++++\n test/camera/meson.build | 1 +\n 2 files changed, 89 insertions(+)\n create mode 100644 test/camera/format_set.cpp","diff":"diff --git a/test/camera/format_set.cpp b/test/camera/format_set.cpp\nnew file mode 100644\nindex 0000000000000000..948428ca6b00d2d0\n--- /dev/null\n+++ b/test/camera/format_set.cpp\n@@ -0,0 +1,88 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * libcamera Camera API tests\n+ */\n+\n+#include \n+\n+#include \"camera_test.h\"\n+\n+using namespace std;\n+\n+namespace {\n+\n+class FormatSet : public CameraTest\n+{\n+protected:\n+\tint run()\n+\t{\n+\t\tif (camera_->acquire()) {\n+\t\t\tcout << \"Acquiring the camera failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tstd::set streams = { *camera_->streams().begin() };\n+\t\tstd::map conf =\n+\t\t\tcamera_->streamConfiguration(streams);\n+\t\tStreamConfiguration *sconf = &conf.begin()->second;\n+\t\tif (conf.size() != 1) {\n+\t\t\tcout << \"Reading default format failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/*\n+\t\t * Test setting the default format works.\n+\t\t */\n+\t\tif (camera_->configureStreams(conf)) {\n+\t\t\tcout << \"Setting valid format test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/*\n+\t\t * Test setting the default format fails the camera is not\n+\t\t * acquired.\n+\t\t */\n+\t\tif (camera_->release()) {\n+\t\t\tcout << \"Releasing the camera failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (!camera_->configureStreams(conf)) {\n+\t\t\tcout << \"Setting valid format on a camera not acquired failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (camera_->acquire()) {\n+\t\t\tcout << \"Acquiring the camera failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/*\n+\t\t * Test doubling the resolution works.\n+\t\t */\n+\t\tsconf->width *= 2;\n+\t\tsconf->height *= 2;\n+\t\tif (camera_->configureStreams(conf)) {\n+\t\t\tcout << \"Setting modified valid format test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/*\n+\t\t * Test Setting an invalid format fails.\n+\t\t */\n+\t\tsconf->width = 0;\n+\t\tsconf->height = 0;\n+\t\tif (!camera_->configureStreams(conf)) {\n+\t\t\tcout << \"Setting invalid format test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+} /* namespace */\n+\n+TEST_REGISTER(FormatSet);\ndiff --git a/test/camera/meson.build b/test/camera/meson.build\nindex 4f2ed244a9240512..f5f27c4229ac307f 100644\n--- a/test/camera/meson.build\n+++ b/test/camera/meson.build\n@@ -2,6 +2,7 @@\n # They are not alphabetically sorted.\n camera_tests = [\n [ 'format_default', 'format_default.cpp' ],\n+ [ 'format_set', 'format_set.cpp' ],\n ]\n \n foreach t : camera_tests\n","prefixes":["libcamera-devel","3/5"]}