{"id":698,"url":"https://patchwork.libcamera.org/api/1.1/patches/698/?format=json","web_url":"https://patchwork.libcamera.org/patch/698/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190301154103.19588-4-jacopo@jmondi.org>","date":"2019-03-01T15:41:01","name":"[libcamera-devel,v7,3/5] libcamera: v4l2_subdevice: Cosmetic update","commit_ref":"00889796830bb46a9dbf2029a059dda90287e3db","pull_url":null,"state":"accepted","archived":false,"hash":"e3f2c639c2f80cd3f0f5b8ce15e5007a8ed93a63","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/698/mbox/","series":[{"id":201,"url":"https://patchwork.libcamera.org/api/1.1/series/201/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=201","date":"2019-03-01T15:40:58","name":"v4l2_(sub)dev: improvements and tests","version":7,"mbox":"https://patchwork.libcamera.org/series/201/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/698/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/698/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A29A6117D\n\tfor ;\n\tFri, 1 Mar 2019 16:40:44 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 81121C0002;\n\tFri, 1 Mar 2019 15:40:43 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 1 Mar 2019 16:41:01 +0100","Message-Id":"<20190301154103.19588-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190301154103.19588-1-jacopo@jmondi.org>","References":"<20190301154103.19588-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v7 3/5] libcamera: v4l2_subdevice:\n\tCosmetic update","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 01 Mar 2019 15:40:44 -0000"},"content":"Cosmetic updated of V4L2Subdevice class: re-sort methods and comments to\nreflect the declaration order in the class definition.\n\nCosmetic update, no functional changes intended.\n\nAcked-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/v4l2_subdevice.cpp | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 394ed0f061f3..5f58904bf9e6 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -54,6 +54,11 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)\n * Section 4.15.3.1 of the above mentioned Linux kernel documentation section.\n */\n \n+/**\n+ * \\var V4L2SubdeviceFormat::mbus_code\n+ * \\brief The image format bus code\n+ */\n+\n /**\n * \\var V4L2SubdeviceFormat::width\n * \\brief The image width in pixels\n@@ -64,11 +69,6 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)\n * \\brief The image height in pixels\n */\n \n-/**\n- * \\var V4L2SubdeviceFormat::mbus_code\n- * \\brief The image format bus code\n- */\n-\n /**\n * \\class V4L2Subdevice\n * \\brief A V4L2 subdevice as exposed by the Linux kernel\n@@ -154,11 +154,6 @@ void V4L2Subdevice::close()\n * \\return The name of the media entity the subdevice is associated to\n */\n \n-std::string V4L2Subdevice::logPrefix() const\n-{\n-\treturn \"'\" + deviceName() + \"'\";\n-}\n-\n /**\n * \\brief Set a crop rectangle on one of the V4L2 subdevice pads\n * \\param[in] pad The 0-indexed pad number the rectangle is to be applied to\n@@ -301,6 +296,11 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format)\n \treturn 0;\n }\n \n+std::string V4L2Subdevice::logPrefix() const\n+{\n+\treturn \"'\" + deviceName() + \"'\";\n+}\n+\n int V4L2Subdevice::enumPadSizes(unsigned int pad,unsigned int code,\n \t\t\t\tstd::vector *sizes)\n {\n","prefixes":["libcamera-devel","v7","3/5"]}