{"id":692,"url":"https://patchwork.libcamera.org/api/1.1/patches/692/?format=json","web_url":"https://patchwork.libcamera.org/patch/692/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190301115139.11060-4-jacopo@jmondi.org>","date":"2019-03-01T11:51:37","name":"[libcamera-devel,v6,3/5] libcamera: v4l2_subdevice: Cosmetic update","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a85bf9c4f603a1a3478b0b20795cff6c2b725403","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/692/mbox/","series":[{"id":200,"url":"https://patchwork.libcamera.org/api/1.1/series/200/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=200","date":"2019-03-01T11:51:34","name":"v4l2_(sub)dev: improvements and tests","version":6,"mbox":"https://patchwork.libcamera.org/series/200/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/692/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/692/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CEF661114\n\tfor ;\n\tFri, 1 Mar 2019 12:52:46 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AAC95C0015;\n\tFri, 1 Mar 2019 11:52:44 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 1 Mar 2019 12:51:37 +0100","Message-Id":"<20190301115139.11060-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190301115139.11060-1-jacopo@jmondi.org>","References":"<20190301115139.11060-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 3/5] libcamera: v4l2_subdevice:\n\tCosmetic update","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 01 Mar 2019 11:52:46 -0000"},"content":"Cosmetic updated of V4L2Subdevice class: re-sort methods and comments to\nreflect the declaration order in the class definition.\n\nCosmetic update, no functional changes intended.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/v4l2_subdevice.cpp | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 07035886c766..de006b898af9 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -54,6 +54,11 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)\n * Section 4.15.3.1 of the above mentioned Linux kernel documentation section.\n */\n \n+/**\n+ * \\var V4L2SubdeviceFormat::mbus_code\n+ * \\brief The image format bus code\n+ */\n+\n /**\n * \\var V4L2SubdeviceFormat::width\n * \\brief The image width in pixels\n@@ -64,11 +69,6 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)\n * \\brief The image height in pixels\n */\n \n-/**\n- * \\var V4L2SubdeviceFormat::mbus_code\n- * \\brief The image format bus code\n- */\n-\n /**\n * \\class V4L2Subdevice\n * \\brief A V4L2 subdevice as exposed by the Linux kernel\n@@ -154,11 +154,6 @@ void V4L2Subdevice::close()\n * \\return The name of the media entity the subdevice is associated to\n */\n \n-std::string V4L2Subdevice::logPrefix() const\n-{\n-\treturn \"'\" + deviceName() + \"'\";\n-}\n-\n /**\n * \\brief Set a crop rectangle on one of the V4L2 subdevice pads\n * \\param[in] pad The 0-indexed pad number the rectangle is to be applied to\n@@ -299,6 +294,11 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format)\n \treturn 0;\n }\n \n+std::string V4L2Subdevice::logPrefix() const\n+{\n+\treturn \"'\" + deviceName() + \"'\";\n+}\n+\n std::vector V4L2Subdevice::enumPadSizes(unsigned int pad,\n \t\t\t\t\t\t unsigned int code)\n {\n","prefixes":["libcamera-devel","v6","3/5"]}