{"id":69,"url":"https://patchwork.libcamera.org/api/1.1/patches/69/?format=json","web_url":"https://patchwork.libcamera.org/patch/69/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20181221081311.3291-4-kieran.bingham@ideasonboard.com>","date":"2018-12-21T08:13:09","name":"[libcamera-devel,3/5] test: libtest: Return all non-zero init values","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"59b0412bd614f6cca875afa47bc0b42a43e8461c","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/69/mbox/","series":[{"id":35,"url":"https://patchwork.libcamera.org/api/1.1/series/35/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=35","date":"2018-12-21T08:13:06","name":"test: Define libtest","version":1,"mbox":"https://patchwork.libcamera.org/series/35/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/69/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/69/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2497560B0C\n\tfor ;\n\tFri, 21 Dec 2018 09:13:21 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B11C059D;\n\tFri, 21 Dec 2018 09:13:20 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1545380000;\n\tbh=BFM1NP2krs11zA02ifV8CXfvRZDRo5Sx3781VKuO7rk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jxCsAmPbjdE7Bo+CMVcXtTXMDliwNO4mQuDeYBwncwmRqKRkRml8+CW1cN0/kCk5f\n\t0EliQxXj0BwDB5VqQ81Yn928SOVePmNbpAubKuABi8LN+aLKr36DJsEd22gztI2CLB\n\t+pHwxE8fj0ywWyg6BwuBWlQjPbBona3WshAndMlQ=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Fri, 21 Dec 2018 08:13:09 +0000","Message-Id":"<20181221081311.3291-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20181221081311.3291-1-kieran.bingham@ideasonboard.com>","References":"<20181221081311.3291-1-kieran.bingham@ideasonboard.com>","Subject":"[libcamera-devel] [PATCH 3/5] test: libtest: Return all non-zero\n\tinit values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 21 Dec 2018 08:13:21 -0000"},"content":"A skipped test is currently defined as returning 77. If this is returned\nby the init stage, currently the execute call will continue on to the\nrun stage.\n\nCorrect this such that any non-zero return code from the init phase will\nabort the test.\n\nSigned-off-by: Kieran Bingham \n---\n test/libtest/test.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/test/libtest/test.cpp b/test/libtest/test.cpp\nindex 1bb6ebcb9e8a..9d537ea08698 100644\n--- a/test/libtest/test.cpp\n+++ b/test/libtest/test.cpp\n@@ -20,7 +20,7 @@ int Test::execute()\n \tint ret;\n \n \tret = init();\n-\tif (ret < 0)\n+\tif (ret)\n \t\treturn ret;\n \n \tret = run();\n","prefixes":["libcamera-devel","3/5"]}