{"id":67,"url":"https://patchwork.libcamera.org/api/1.1/patches/67/?format=json","web_url":"https://patchwork.libcamera.org/patch/67/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20181221081311.3291-2-kieran.bingham@ideasonboard.com>","date":"2018-12-21T08:13:07","name":"[libcamera-devel,1/5] test: Move test objects to libtest","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bb370ac1c1db95b5b20b43b53ef849bded5e631b","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/67/mbox/","series":[{"id":35,"url":"https://patchwork.libcamera.org/api/1.1/series/35/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=35","date":"2018-12-21T08:13:06","name":"test: Define libtest","version":1,"mbox":"https://patchwork.libcamera.org/series/35/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/67/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/67/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EDAE60B0C\n\tfor ;\n\tFri, 21 Dec 2018 09:13:20 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 08ADE565;\n\tFri, 21 Dec 2018 09:13:19 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1545380000;\n\tbh=Ov6XvFZsnF/Fl+M4+x3oKRBCmE7J93rUz5NSM4nQDMo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=i9K5IpP1LYAUzBgEF8GmOrs4Y2TiX4oN4IJfOvVzoKjWngxzXxKX/N85i+05reKia\n\tpHVn71KSdIe/VbgcvkF5fQ+AcpVfynX+R6NH5S7VWVP4jFXTraZj22Mla2Wdlx3bzI\n\tlm21UasOcw7ARL4pv2ysb2mAXw011dM+94jbJfDI=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Fri, 21 Dec 2018 08:13:07 +0000","Message-Id":"<20181221081311.3291-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20181221081311.3291-1-kieran.bingham@ideasonboard.com>","References":"<20181221081311.3291-1-kieran.bingham@ideasonboard.com>","Subject":"[libcamera-devel] [PATCH 1/5] test: Move test objects to libtest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 21 Dec 2018 08:13:20 -0000"},"content":"Create a subdirectory to contain the libtest helper library.\n\nDefine two variables to clarify when tests are aimed at public or\ninternal components.\n\nSigned-off-by: Kieran Bingham \n---\n test/libtest/meson.build | 7 +++++++\n test/{ => libtest}/test.cpp | 0\n test/{ => libtest}/test.h | 0\n test/meson.build | 20 ++++++++++++++------\n 4 files changed, 21 insertions(+), 6 deletions(-)\n create mode 100644 test/libtest/meson.build\n rename test/{ => libtest}/test.cpp (100%)\n rename test/{ => libtest}/test.h (100%)","diff":"diff --git a/test/libtest/meson.build b/test/libtest/meson.build\nnew file mode 100644\nindex 000000000000..b998154dd8d3\n--- /dev/null\n+++ b/test/libtest/meson.build\n@@ -0,0 +1,7 @@\n+libtest_sources = files([\n+ 'test.cpp',\n+])\n+\n+libtest = static_library('libtest', libtest_sources)\n+\n+libtest_includes = include_directories('.')\ndiff --git a/test/test.cpp b/test/libtest/test.cpp\nsimilarity index 100%\nrename from test/test.cpp\nrename to test/libtest/test.cpp\ndiff --git a/test/test.h b/test/libtest/test.h\nsimilarity index 100%\nrename from test/test.h\nrename to test/libtest/test.h\ndiff --git a/test/meson.build b/test/meson.build\nindex da0aea9678d1..50ec11853203 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -1,11 +1,19 @@\n-libtest_sources = files([\n- 'test.cpp',\n-])\n+subdir('libtest')\n \n-libtest = static_library('libtest', libtest_sources)\n+test_libraries = [libcamera, libtest]\n+\n+test_includes_public = [\n+ libtest_includes,\n+ libcamera_includes,\n+]\n+\n+test_includes_internal = [\n+ test_includes_public,\n+ libcamera_internal_includes,\n+]\n \n test_init = executable('test_init', 'init.cpp',\n- link_with : libcamera,\n- include_directories : libcamera_includes)\n+ link_with : test_libraries,\n+ include_directories : test_includes_public)\n \n test('Initialisation test', test_init)\n","prefixes":["libcamera-devel","1/5"]}