{"id":628,"url":"https://patchwork.libcamera.org/api/1.1/patches/628/?format=json","web_url":"https://patchwork.libcamera.org/patch/628/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190226021857.28255-8-niklas.soderlund@ragnatech.se>","date":"2019-02-26T02:18:56","name":"[libcamera-devel,7/8] libcamera: camera: ensure streams belong to camera","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4fd049b21329729e8fc1e4acccf3bf906553ae6f","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/628/mbox/","series":[{"id":192,"url":"https://patchwork.libcamera.org/api/1.1/series/192/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=192","date":"2019-02-26T02:18:50","name":"libcamera: improve validation of camera operations","version":1,"mbox":"https://patchwork.libcamera.org/series/192/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/628/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/628/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D8FC601E2\n\tfor ;\n\tTue, 26 Feb 2019 03:19:29 +0100 (CET)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid efd1ff10-396c-11e9-985a-005056917f90;\n\tTue, 26 Feb 2019 03:19:27 +0100 (CET)"],"X-Halon-ID":"efd1ff10-396c-11e9-985a-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Feb 2019 03:18:56 +0100","Message-Id":"<20190226021857.28255-8-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190226021857.28255-1-niklas.soderlund@ragnatech.se>","References":"<20190226021857.28255-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 7/8] libcamera: camera: ensure streams\n\tbelong to camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 26 Feb 2019 02:19:29 -0000"},"content":"Before calling into the pipeline handler make sure the streams provided\nby the application actually belongs to the camera.\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/camera.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 938f21fe80ef8ceb..ba8638009992170f 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -253,6 +253,10 @@ Camera::streamConfiguration(std::set &streams)\n \tif (!stateIsAtleast(Free) || !streams.size())\n \t\treturn std::map{};\n \n+\tfor (Stream *stream : streams)\n+\t\tif (streams_.find(stream) == streams_.end())\n+\t\t\treturn std::map{};\n+\n \treturn pipe_->streamConfiguration(this, streams);\n }\n \n@@ -290,6 +294,10 @@ int Camera::configureStreams(std::map &config)\n \t\treturn -EINVAL;\n \t}\n \n+\tfor (auto const &iter : config)\n+\t\tif (streams_.find(iter.first) == streams_.end())\n+\t\t\treturn -EINVAL;\n+\n \tret = pipe_->configureStreams(this, config);\n \tif (ret)\n \t\treturn ret;\n","prefixes":["libcamera-devel","7/8"]}