{"id":610,"url":"https://patchwork.libcamera.org/api/1.1/patches/610/?format=json","web_url":"https://patchwork.libcamera.org/patch/610/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190224173701.8587-2-niklas.soderlund@ragnatech.se>","date":"2019-02-24T17:36:58","name":"[libcamera-devel,v2,1/4] libcamera: pipeline_handler: extend documentation for configureStreams()","commit_ref":"9a37b4c5a8452afd3cf19dc915c5460408171e5f","pull_url":null,"state":"accepted","archived":false,"hash":"f9e225a503e2d2c2a7b64b2e9f7dc0996ceb3ed9","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/610/mbox/","series":[{"id":190,"url":"https://patchwork.libcamera.org/api/1.1/series/190/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=190","date":"2019-02-24T17:36:57","name":"libcamera: enforce stream configuration","version":2,"mbox":"https://patchwork.libcamera.org/series/190/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/610/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/610/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DB95601E2\n\tfor ;\n\tSun, 24 Feb 2019 18:37:11 +0100 (CET)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid d01e8a70-385a-11e9-b5ae-0050569116f7;\n\tSun, 24 Feb 2019 18:37:10 +0100 (CET)"],"X-Halon-ID":"d01e8a70-385a-11e9-b5ae-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 24 Feb 2019 18:36:58 +0100","Message-Id":"<20190224173701.8587-2-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190224173701.8587-1-niklas.soderlund@ragnatech.se>","References":"<20190224173701.8587-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/4] libcamera: pipeline_handler:\n\textend documentation for configureStreams()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 24 Feb 2019 17:37:11 -0000"},"content":"Extend the documentation to explicitly state that the pipeline handler\nimplementations are responsible for validating that the requested\nconfiguration can be exactly satisfied by the hardware.\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/pipeline_handler.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 616838fed702fec7..dad0a2964486c5d4 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -136,6 +136,14 @@ PipelineHandler::~PipelineHandler()\n * is the Camera class which will receive configuration to apply from the\n * application.\n *\n+ * Each pipeline handler implementation is responsible for validating\n+ * that the configuration requested in \\a config can be achieved\n+ * exactly. Any difference in pixel format, frame size or any other\n+ * parameter shall result in the -EINVAL error being returned, and no\n+ * change in configuration being applied to the pipeline. If\n+ * configuration of a subset of the streams can't be satisfied, the\n+ * whole configuration is considered invalid.\n+ *\n * \\return 0 on success or a negative error code on error.\n */\n \n","prefixes":["libcamera-devel","v2","1/4"]}