{"id":586,"url":"https://patchwork.libcamera.org/api/1.1/patches/586/?format=json","web_url":"https://patchwork.libcamera.org/patch/586/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190219165620.2385-3-jacopo@jmondi.org>","date":"2019-02-19T16:56:19","name":"[libcamera-devel,2/3] libcamera: v4l2_subdevice: Add subdevice name","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7706a8026ea177062c1c46e40c6f78df0d9ee503","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/1.1/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/586/mbox/","series":[{"id":185,"url":"https://patchwork.libcamera.org/api/1.1/series/185/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=185","date":"2019-02-19T16:56:17","name":"libcamera: v4l2_subdev and v4l2_device mixed","version":1,"mbox":"https://patchwork.libcamera.org/series/185/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/586/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/586/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4682F600FD\n\tfor ;\n\tTue, 19 Feb 2019 17:56:03 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D1088E000C;\n\tTue, 19 Feb 2019 16:56:02 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 19 Feb 2019 17:56:19 +0100","Message-Id":"<20190219165620.2385-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190219165620.2385-1-jacopo@jmondi.org>","References":"<20190219165620.2385-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/3] libcamera: v4l2_subdevice: Add\n\tsubdevice name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 19 Feb 2019 16:56:03 -0000"},"content":"Add a deviceName_ field that contains the human readable name of the\nsubdevice, which is created using the name of the associated media\nentity.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/include/v4l2_subdevice.h | 2 ++\n src/libcamera/v4l2_subdevice.cpp | 9 ++++++++-\n 2 files changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\nindex c7045776555c..40becd0ca99b 100644\n--- a/src/libcamera/include/v4l2_subdevice.h\n+++ b/src/libcamera/include/v4l2_subdevice.h\n@@ -42,6 +42,7 @@ public:\n \tvoid close();\n \n \tstd::string deviceNode() const { return deviceNode_; }\n+\tstd::string deviceName() const { return deviceName_; }\n \n \tint setCrop(unsigned int pad, Rectangle *rect);\n \tint setCompose(unsigned int pad, Rectangle *rect);\n@@ -55,6 +56,7 @@ private:\n \t\t\t Rectangle *rect);\n \n \tstd::string deviceNode_;\n+\tstd::string deviceName_;\n \tint fd_;\n };\n \ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 5665154a2762..4411ffa51460 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -134,7 +134,7 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)\n * path\n */\n V4L2Subdevice::V4L2Subdevice(const MediaEntity *entity)\n-\t: deviceNode_(entity->deviceNode()), fd_(-1)\n+\t: deviceNode_(entity->deviceNode()), deviceName_(entity->name()), fd_(-1)\n {\n }\n \n@@ -193,6 +193,13 @@ void V4L2Subdevice::close()\n * \\return The subdevice's device node system path\n */\n \n+/**\n+ * \\fn V4L2Subdevice::deviceName()\n+ * \\brief Retrieve the name of the media entity associated with the subdevice\n+ *\n+ * \\return The name of the media entity the subdevice is associated to\n+ */\n+\n /**\n * \\brief Set a crop rectangle on one of the V4L2 subdevice pads\n * \\param[in] pad The 0-indexed pad number the rectangle is to be applied to\n","prefixes":["libcamera-devel","2/3"]}