{"id":580,"url":"https://patchwork.libcamera.org/api/1.1/patches/580/?format=json","web_url":"https://patchwork.libcamera.org/patch/580/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190213171453.13852-3-kieran.bingham@ideasonboard.com>","date":"2019-02-13T17:14:52","name":"[libcamera-devel,v3,2/3] test: v4l2_device: release capture device resources","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0976c579a09698fa5c433a71059dfd53cda6d6b3","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/580/mbox/","series":[{"id":182,"url":"https://patchwork.libcamera.org/api/1.1/series/182/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=182","date":"2019-02-13T17:14:50","name":"libcamera: test: buffer_sharing","version":3,"mbox":"https://patchwork.libcamera.org/series/182/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/580/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/580/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D764610B6\n\tfor ;\n\tWed, 13 Feb 2019 18:14:58 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6ADA9A5;\n\tWed, 13 Feb 2019 18:14:57 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550078097;\n\tbh=18IbC9OS1RlWJ0xdfXU5Yu33UXrAai8Z1rMO0LVlN1s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=S35uEVCauFfFoTtCRaH8bJXhHtpO+qQDbuGBqk/THxcgUKsc37kqFq6HoXBmPWmt9\n\tHLq/xGejmRz8gIfUpmYXjtYMSQxnrM42xxacEhF3w78i4Zr/hyEjYjRznXzD/plyuB\n\tpi/IErpYQtYJA9UXl5IEvfdmpKewP8crV0C0s2+A=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Wed, 13 Feb 2019 17:14:52 +0000","Message-Id":"<20190213171453.13852-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.19.1","In-Reply-To":"<20190213171453.13852-1-kieran.bingham@ideasonboard.com>","References":"<20190213171453.13852-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 2/3] test: v4l2_device: release capture\n\tdevice resources","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 Feb 2019 17:14:58 -0000"},"content":"Ensure that the cleanup operation releases the device and resources.\n\nSigned-off-by: Kieran Bingham \n---\n test/v4l2_device/v4l2_device_test.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/test/v4l2_device/v4l2_device_test.cpp b/test/v4l2_device/v4l2_device_test.cpp\nindex 2bdf8cfe983a..4225291bbb6e 100644\n--- a/test/v4l2_device/v4l2_device_test.cpp\n+++ b/test/v4l2_device/v4l2_device_test.cpp\n@@ -63,5 +63,9 @@ void V4L2DeviceTest::cleanup()\n {\n \tmedia_->release();\n \n+\tcapture_->streamOff();\n+\tcapture_->releaseBuffers();\n+\tcapture_->close();\n+\n \tdelete capture_;\n };\n","prefixes":["libcamera-devel","v3","2/3"]}