{"id":565,"url":"https://patchwork.libcamera.org/api/1.1/patches/565/?format=json","web_url":"https://patchwork.libcamera.org/patch/565/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190213122035.25309-2-kieran.bingham@ideasonboard.com>","date":"2019-02-13T12:20:33","name":"[libcamera-devel,1/3] libcamera: v4l2_device: Fix LOG usage","commit_ref":"0a443b589bfac5b726c1beaef047e59a6f0b3841","pull_url":null,"state":"accepted","archived":false,"hash":"fe8c4c7946c8afc6e002e3eff351763dd9fef49c","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/565/mbox/","series":[{"id":179,"url":"https://patchwork.libcamera.org/api/1.1/series/179/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=179","date":"2019-02-13T12:20:32","name":"Fix LOG usage","version":1,"mbox":"https://patchwork.libcamera.org/series/179/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/565/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/565/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF5816101F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Feb 2019 13:20:39 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51A71304;\n\tWed, 13 Feb 2019 13:20:39 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550060439;\n\tbh=pL3qFJPckIIefvvoNklKfXVSsOSfhOJZpk3CRwOqITw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tZRud8MMrM4DpneY/yFNPaB4lK4RSX1NXe9hXYAjkAfS7elZJ5XJNytrTIFzentYF\n\tP3o4fKU09ELrOwHRS8GbNeHjwro4zswrDATqgGAcxUdGgCdZRJMY+zozBR/C7B4YEf\n\toutPM/gk5GUFNDHbuJZejQhyy3jU8yDaBqHtDWUY=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Date":"Wed, 13 Feb 2019 12:20:33 +0000","Message-Id":"<20190213122035.25309-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.19.1","In-Reply-To":"<20190213122035.25309-1-kieran.bingham@ideasonboard.com>","References":"<20190213122035.25309-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/3] libcamera: v4l2_device: Fix LOG usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 13 Feb 2019 12:20:40 -0000"},"content":"Add the V4L2 category to the LOG() statements.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/v4l2_device.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 683090abc8e5..d92e20b97d50 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -390,7 +390,7 @@ int V4L2Device::getFormatSingleplane(V4L2DeviceFormat *format)\n \tret = ioctl(fd_, VIDIOC_G_FMT, &v4l2Format);\n \tif (ret) {\n \t\tret = -errno;\n-\t\tLOG(Error) << \"Unable to get format: \" << strerror(-ret);\n+\t\tLOG(V4L2, Error) << \"Unable to get format: \" << strerror(-ret);\n \t\treturn ret;\n \t}\n \n@@ -419,7 +419,7 @@ int V4L2Device::setFormatSingleplane(V4L2DeviceFormat *format)\n \tret = ioctl(fd_, VIDIOC_S_FMT, &v4l2Format);\n \tif (ret) {\n \t\tret = -errno;\n-\t\tLOG(Error) << \"Unable to set format: \" << strerror(-ret);\n+\t\tLOG(V4L2, Error) << \"Unable to set format: \" << strerror(-ret);\n \t\treturn ret;\n \t}\n \n@@ -447,7 +447,7 @@ int V4L2Device::getFormatMultiplane(V4L2DeviceFormat *format)\n \tret = ioctl(fd_, VIDIOC_G_FMT, &v4l2Format);\n \tif (ret) {\n \t\tret = -errno;\n-\t\tLOG(Error) << \"Unable to get format: \" << strerror(-ret);\n+\t\tLOG(V4L2, Error) << \"Unable to get format: \" << strerror(-ret);\n \t\treturn ret;\n \t}\n \n@@ -484,7 +484,7 @@ int V4L2Device::setFormatMultiplane(V4L2DeviceFormat *format)\n \tret = ioctl(fd_, VIDIOC_S_FMT, &v4l2Format);\n \tif (ret) {\n \t\tret = -errno;\n-\t\tLOG(Error) << \"Unable to set format: \" << strerror(-ret);\n+\t\tLOG(V4L2, Error) << \"Unable to set format: \" << strerror(-ret);\n \t\treturn ret;\n \t}\n \n","prefixes":["libcamera-devel","1/3"]}