{"id":525,"url":"https://patchwork.libcamera.org/api/1.1/patches/525/?format=json","web_url":"https://patchwork.libcamera.org/patch/525/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190206060818.13907-11-laurent.pinchart@ideasonboard.com>","date":"2019-02-06T06:08:01","name":"[libcamera-devel,10/27] libcamera: v4l2_device: Add comments to method parameters","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"08535517c6cc04309849b6ea70aa275149971b91","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/525/mbox/","series":[{"id":170,"url":"https://patchwork.libcamera.org/api/1.1/series/170/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=170","date":"2019-02-06T06:07:51","name":"Capture frames throught requests","version":1,"mbox":"https://patchwork.libcamera.org/series/170/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/525/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/525/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B708A61020\n\tfor ;\n\tWed, 6 Feb 2019 07:08:25 +0100 (CET)","from pendragon.ideasonboard.com (d51A4137F.access.telenet.be\n\t[81.164.19.127])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6065A2D8\n\tfor ;\n\tWed, 6 Feb 2019 07:08:25 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549433305;\n\tbh=ed7zAfnTyKzgGDl6z7BGBCASUoPoQdL+D+VYDrRhisM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=FnYWRaoE4hQt4oOWkrW4PRyq1W3TqUVBrz10DJkqKO8xgtOduSaXWLevrL2eMIMWQ\n\tNW7lOZMICxRlyCihvM5JUywlwHnSZlDKp7aUccMp9FQeNpqFNvQUy0G82XPCerDrLD\n\tbIRkQsVpmkucdp9GGMMU93/VyQV3RfBWVmznHXn0=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 6 Feb 2019 08:08:01 +0200","Message-Id":"<20190206060818.13907-11-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.19.2","In-Reply-To":"<20190206060818.13907-1-laurent.pinchart@ideasonboard.com>","References":"<20190206060818.13907-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 10/27] libcamera: v4l2_device: Add\n\tcomments to method parameters","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 06 Feb 2019 06:08:27 -0000"},"content":"From: Jacopo Mondi \n\nAdd missing parameter documentation for set and get format methods.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Niklas Söderlund \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/v4l2_device.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex e8755be1f63f..64325ff9f5d9 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -352,6 +352,8 @@ void V4L2Device::close()\n \n /**\n * \\brief Retrieve the image format set on the V4L2 device\n+ * \\param[out] format The image format applied on the device\n+ *\n * \\return 0 for success, a negative error code otherwise\n */\n int V4L2Device::getFormat(V4L2DeviceFormat *format)\n@@ -362,6 +364,7 @@ int V4L2Device::getFormat(V4L2DeviceFormat *format)\n \n /**\n * \\brief Configure an image format on the V4L2 device\n+ * \\param[in] format The image format to apply to the device\n *\n * Apply the supplied \\a format to the device, and return the actually\n * applied format parameters, as \\ref V4L2Device::getFormat would do.\n","prefixes":["libcamera-devel","10/27"]}