{"id":502,"url":"https://patchwork.libcamera.org/api/1.1/patches/502/?format=json","web_url":"https://patchwork.libcamera.org/patch/502/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190204185521.23471-3-niklas.soderlund@ragnatech.se>","date":"2019-02-04T18:55:21","name":"[libcamera-devel,2/2] libcamera: pipeline: uvcvideo: set a default format","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cc240e7229b297bdd1951b2eb3b78cf30ce77e2e","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/502/mbox/","series":[{"id":167,"url":"https://patchwork.libcamera.org/api/1.1/series/167/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=167","date":"2019-02-04T18:55:19","name":"libcamera: pipeline: uvcvideo: set a default format","version":1,"mbox":"https://patchwork.libcamera.org/series/167/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/502/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/502/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 931FC60DB7\n\tfor ;\n\tMon, 4 Feb 2019 19:55:33 +0100 (CET)","from localhost.localdomain (unknown [81.164.19.127])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 71689809-28ae-11e9-a58a-005056917f90;\n\tMon, 04 Feb 2019 19:55:30 +0100 (CET)"],"X-Halon-ID":"71689809-28ae-11e9-a58a-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 4 Feb 2019 19:55:21 +0100","Message-Id":"<20190204185521.23471-3-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190204185521.23471-1-niklas.soderlund@ragnatech.se>","References":"<20190204185521.23471-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] libcamera: pipeline: uvcvideo: set a\n\tdefault format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 04 Feb 2019 18:55:34 -0000"},"content":"Pick a default format for the UVC one stream in a UVC camera. This is\njust a starting point to define a good default format for the UVC camera\nit's expected to evolve over time as the capabilities of the library\ngrows.\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/pipeline/uvcvideo.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\nindex 821e4c2189caabd0..ad4d45d0698519b6 100644\n--- a/src/libcamera/pipeline/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo.cpp\n@@ -60,7 +60,11 @@ PipelineHandlerUVC::streamConfiguration(Camera *camera,\n \n \tStreamConfiguration config{};\n \n-\tLOG(UVC, Info) << \"TODO: Return a good default format\";\n+\tLOG(UVC, Debug) << \"Retrieving default format\";\n+\tconfig.width = 640;\n+\tconfig.height = 480;\n+\tconfig.pixelFormat = V4L2_PIX_FMT_YUYV;\n+\tconfig.bufferCount = 4;\n \n \tconfigs[&stream_] = config;\n \n","prefixes":["libcamera-devel","2/2"]}