{"id":501,"url":"https://patchwork.libcamera.org/api/1.1/patches/501/?format=json","web_url":"https://patchwork.libcamera.org/patch/501/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190204185521.23471-2-niklas.soderlund@ragnatech.se>","date":"2019-02-04T18:55:20","name":"[libcamera-devel,1/2] libcamera: streams: extend stream configuration with buffer count","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6465778bd1badf5e0c8135bf865e70c4c3573189","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/501/mbox/","series":[{"id":167,"url":"https://patchwork.libcamera.org/api/1.1/series/167/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=167","date":"2019-02-04T18:55:19","name":"libcamera: pipeline: uvcvideo: set a default format","version":1,"mbox":"https://patchwork.libcamera.org/series/167/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/501/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/501/checks/","tags":{},"headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19BB260B2D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  4 Feb 2019 19:55:32 +0100 (CET)","from localhost.localdomain (unknown [81.164.19.127])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 70d16a75-28ae-11e9-a58a-005056917f90;\n\tMon, 04 Feb 2019 19:55:29 +0100 (CET)"],"X-Halon-ID":"70d16a75-28ae-11e9-a58a-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon,  4 Feb 2019 19:55:20 +0100","Message-Id":"<20190204185521.23471-2-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190204185521.23471-1-niklas.soderlund@ragnatech.se>","References":"<20190204185521.23471-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] libcamera: streams: extend stream\n\tconfiguration with buffer count","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 04 Feb 2019 18:55:32 -0000"},"content":"The camera needs to be configured with the number of buffers to use to\nsatisfy the application use-case. While it's free for the application to\nrequest any number of buffers the pipeline needs to take the Linux\ndrivers constraints into consideration.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/stream.h | 2 ++\n src/libcamera/stream.cpp   | 5 +++++\n 2 files changed, 7 insertions(+)","diff":"diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 4b24dd841dd64b64..890678360ee87fd7 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -17,6 +17,8 @@ struct StreamConfiguration {\n \tunsigned int width;\n \tunsigned int height;\n \tunsigned int pixelFormat;\n+\n+\tunsigned int bufferCount;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex b0b4efe39c81e747..5ebdce9acdbd3560 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -73,4 +73,9 @@ namespace libcamera {\n  * format described in V4L2 using the V4L2_PIX_FMT_* definitions.\n  */\n \n+/**\n+ * \\var StreamConfiguration::bufferCount\n+ * \\brief Number of buffers to allocate for the stream\n+ */\n+\n } /* namespace libcamera */\n","prefixes":["libcamera-devel","1/2"]}