{"id":4201,"url":"https://patchwork.libcamera.org/api/1.1/patches/4201/?format=json","web_url":"https://patchwork.libcamera.org/patch/4201/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200625012335.7717-1-laurent.pinchart@ideasonboard.com>","date":"2020-06-25T01:23:35","name":"[libcamera-devel] libcamera: utils: Add map_keys() function","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"27869b01d2de549b889ae6b7b67cc4df7f81db07","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/4201/mbox/","series":[{"id":1038,"url":"https://patchwork.libcamera.org/api/1.1/series/1038/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1038","date":"2020-06-25T01:23:35","name":"[libcamera-devel] libcamera: utils: Add map_keys() function","version":1,"mbox":"https://patchwork.libcamera.org/series/1038/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/4201/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/4201/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57FD2C0100\n\tfor ;\n\tThu, 25 Jun 2020 01:23:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2427D609C6;\n\tThu, 25 Jun 2020 03:23:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1868603BE\n\tfor ;\n\tThu, 25 Jun 2020 03:23:40 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 235AF2A8\n\tfor ;\n\tThu, 25 Jun 2020 03:23:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pPTIeehc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593048220;\n\tbh=ToMwbWqqMERI3NElole+0jhlwow0O7H4xs+ONQChtqM=;\n\th=From:To:Subject:Date:From;\n\tb=pPTIeehcwuGz+KUAFDSbmqXz5iaW0ZRgxoi2aSbmrEHraI00cCgablG8nwfK2TB/V\n\tLMcgqOpUDCqtuc94JtjhKYXOkMzWVCNtmcgRnF/PTI3EGvStyFdbeO6JSOUOuiSypM\n\tU3kDQM1RKjrE2+2O19g8TSPowpZFkPCIG14v4CXY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 25 Jun 2020 04:23:35 +0300","Message-Id":"<20200625012335.7717-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] libcamera: utils: Add map_keys() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a map_keys() function to the utils namespace to extract keys from a\nmap.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/utils.h | 10 ++++++++++\n src/libcamera/utils.cpp | 7 +++++++\n test/utils.cpp | 21 +++++++++++++++++++++\n 3 files changed, 38 insertions(+)","diff":"diff --git a/include/libcamera/internal/utils.h b/include/libcamera/internal/utils.h\nindex 0953423ee8d0..4fe4843922a9 100644\n--- a/include/libcamera/internal/utils.h\n+++ b/include/libcamera/internal/utils.h\n@@ -11,6 +11,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -36,6 +37,15 @@ const char *basename(const char *path);\n char *secure_getenv(const char *name);\n std::string dirname(const std::string &path);\n \n+template\n+std::set map_keys(const T &map)\n+{\n+\tstd::set keys;\n+\tstd::transform(map.begin(), map.end(), std::inserter(keys, keys.end()),\n+\t\t [](const auto &value) { return value.first; });\n+\treturn keys;\n+}\n+\n template\n unsigned int set_overlap(InputIt1 first1, InputIt1 last1,\n \t\t\t InputIt2 first2, InputIt2 last2)\ndiff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\nindex d55338fe681a..1eb8970a5bbc 100644\n--- a/src/libcamera/utils.cpp\n+++ b/src/libcamera/utils.cpp\n@@ -127,6 +127,13 @@ std::string dirname(const std::string &path)\n \treturn path.substr(0, pos + 1);\n }\n \n+/**\n+ * \\fn std::set map_keys(const T &map)\n+ * \\brief Retrieve the keys of a std::map<>\n+ * \\param[in] map The map whose keys to retrieve\n+ * \\return A std::set<> containing the keys of \\a map\n+ */\n+\n /**\n * \\fn libcamera::utils::set_overlap(InputIt1 first1, InputIt1 last1,\n *\t\t\t\t InputIt2 first2, InputIt2 last2)\ndiff --git a/test/utils.cpp b/test/utils.cpp\nindex 66b91f1203e1..a9d072030f1c 100644\n--- a/test/utils.cpp\n+++ b/test/utils.cpp\n@@ -6,6 +6,8 @@\n */\n \n #include \n+#include \n+#include \n #include \n #include \n #include \n@@ -144,6 +146,25 @@ protected:\n \t\tif (TestPass != testDirname())\n \t\t\treturn TestFail;\n \n+\n+\t\t/* utils::map_keys() test. */\n+\t\tconst std::map map{\n+\t\t\t{ \"zero\", 0 },\n+\t\t\t{ \"one\", 1 },\n+\t\t\t{ \"two\", 2 },\n+\t\t};\n+\t\tconst std::set expectedKeys{\n+\t\t\t\"zero\",\n+\t\t\t\"one\",\n+\t\t\t\"two\",\n+\t\t};\n+\n+\t\tconst std::set keys = utils::map_keys(map);\n+\t\tif (keys != expectedKeys) {\n+\t\t\tcerr << \"utils::map_keys() test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\treturn TestPass;\n \t}\n };\n","prefixes":["libcamera-devel"]}