{"id":4027,"url":"https://patchwork.libcamera.org/api/1.1/patches/4027/?format=json","web_url":"https://patchwork.libcamera.org/patch/4027/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200611171528.9381-4-email@uajain.com>","date":"2020-06-11T17:16:05","name":"[libcamera-devel,v4,3/6] libcamera: device_enumerator: Emit a signal when a new devices are added","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6d35c3e99fdf4995eb0503f2bb86f710530f53e2","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/4027/mbox/","series":[{"id":993,"url":"https://patchwork.libcamera.org/api/1.1/series/993/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=993","date":"2020-06-11T17:16:02","name":"Introduce UVC hotplugging support","version":4,"mbox":"https://patchwork.libcamera.org/series/993/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/4027/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/4027/checks/","tags":{},"headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 952D961027\n\tfor ;\n\tThu, 11 Jun 2020 19:16:06 +0200 (CEST)","by filterdrecv-p3iad2-784dbb6bd8-jftzh with SMTP id\n\tfilterdrecv-p3iad2-784dbb6bd8-jftzh-17-5EE266D5-23\n\t2020-06-11 17:16:05.310937936 +0000 UTC m=+680954.236033796","from mail.uajain.com (unknown)\n\tby ismtpd0001p1hnd1.sendgrid.net (SG) with ESMTP\n\tid BQmhn86PQSKaruCQddJE9A Thu, 11 Jun 2020 17:16:04.923 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"n+xRptwD\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=hy9kPHlRcNDPV9xcmzuBcY0diH6AD2OeqkMd1R7orls=;\n\tb=n+xRptwDuTQTuFp1LzmiK1A+id2reV4JR1AsZFdwiq0D6omMgytXLjR76gtnz03joT84\n\tgR/E+8ZVv9IEB5kL+sVCLiOcbPAmoxIEEr8dCE2GfDqr5xl00JYauPtbjHA2+nTS/t4gnu\n\tfqRALGGuBGYrVyxgzlIdtI+LU833MS/Nc=","From":"Umang Jain ","Date":"Thu, 11 Jun 2020 17:16:05 +0000 (UTC)","Message-Id":"<20200611171528.9381-4-email@uajain.com>","In-Reply-To":"<20200611171528.9381-1-email@uajain.com>","References":"<20200611171528.9381-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcofpXQ1KwJPJayd5tGsU1eP6ax03JDjPaDSEaSM2mPEVoxIECu4EqLbxhCzPjDh7ubXCNxFCfLoNsveqR5JoGf3wpL7FfNtcTyZfgF33X8BDEhnu1AYYqNBgD7T5GUmG0ZuArQebzDv0ZCAunIpmQrVE612Ua9baS7/uKDeFuqjGQbNxZPoPLF1z5fDP/g/P2JDC0J+AhF+wzTK/+5XHImQ==","To":"laurent.pinchart@ideasonboard.com, libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH v4 3/6] libcamera: device_enumerator: Emit\n\ta signal when a new devices are added","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 11 Jun 2020 17:16:07 -0000"},"content":"Emit a signal whenever a new MediaDevices are added to the\nDeviceEnumerator. This will allow CameraManager to be notified\nabout the new devices and it can re-emumerate all the devices\ncurrently present on the system.\n\nDevice enumeration by the CameraManger is a expensive operation hence,\nwe want one signal emission per 'x' milliseconds to notify multiple\ndevices additions as a single batch, by the DeviceEnumerator.\nAdd a \\todo to investigate the support for that.\n\nSigned-off-by: Umang Jain \nReviewed-by: Laurent Pinchart \n---\n include/libcamera/internal/device_enumerator.h | 4 ++++\n src/libcamera/camera_manager.cpp | 4 ++--\n src/libcamera/device_enumerator.cpp | 13 +++++++++++++\n 3 files changed, 19 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/internal/device_enumerator.h b/include/libcamera/internal/device_enumerator.h\nindex 25a3630..a985040 100644\n--- a/include/libcamera/internal/device_enumerator.h\n+++ b/include/libcamera/internal/device_enumerator.h\n@@ -13,6 +13,8 @@\n \n #include \n \n+#include \n+\n namespace libcamera {\n \n class MediaDevice;\n@@ -43,6 +45,8 @@ public:\n \n \tstd::shared_ptr search(const DeviceMatch &dm);\n \n+\tSignal<> devicesAdded;\n+\n protected:\n \tstd::unique_ptr createDevice(const std::string &deviceNode);\n \tvoid addDevice(std::unique_ptr &&media);\ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex aba5a0c..17a4afb 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -155,12 +155,12 @@ void CameraManager::Private::createPipelineHandlers()\n \t\t}\n \t}\n \n-\t/* \\todo Register hot-plug callback here */\n+\tenumerator_->devicesAdded.connect(this, &Private::createPipelineHandlers);\n }\n \n void CameraManager::Private::cleanup()\n {\n-\t/* \\todo Unregister hot-plug callback here */\n+\tenumerator_->devicesAdded.disconnect(this, &Private::createPipelineHandlers);\n \n \t/*\n \t * Release all references to cameras and pipeline handlers to ensure\ndiff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex e21a2a7..e3264a5 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -227,6 +227,16 @@ std::unique_ptr DeviceEnumerator::createDevice(const std::string &d\n \treturn media;\n }\n \n+/**\n+* \\var DeviceEnumerator::devicesAdded\n+* \\brief Notify of new media devices being found\n+*\n+* This signal is emitted when the device enumerator finds new media devices in\n+* the system. It may be emitted for every newly detected device, or once for\n+* multiple of devices, at the discretion of the device enumerator. Not all\n+* device enumerator types may support dynamic detection of new devices.\n+*/\n+\n /**\n * \\brief Add a media device to the enumerator\n * \\param[in] media media device instance to add\n@@ -242,6 +252,9 @@ void DeviceEnumerator::addDevice(std::unique_ptr &&media)\n \t\t<< \"Added device \" << media->deviceNode() << \": \" << media->driver();\n \n \tdevices_.push_back(std::move(media));\n+\n+\t/* \\todo To batch multiple additions, emit with a small delay here. */\n+\tdevicesAdded.emit();\n }\n \n /**\n","prefixes":["libcamera-devel","v4","3/6"]}