{"id":3840,"url":"https://patchwork.libcamera.org/api/1.1/patches/3840/?format=json","web_url":"https://patchwork.libcamera.org/patch/3840/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200522145459.16836-2-laurent.pinchart@ideasonboard.com>","date":"2020-05-22T14:54:48","name":"[libcamera-devel,PATCH/RFC,01/11] libcamera: Rename pixelformats.{cpp, h} to pixel_format.{cpp, h}","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1443621a8cdb139fad884cbdfc408db281cf4afa","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3840/mbox/","series":[{"id":923,"url":"https://patchwork.libcamera.org/api/1.1/series/923/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=923","date":"2020-05-22T14:54:47","name":"Introduce formats:: namespace for libcamera pixel formats","version":1,"mbox":"https://patchwork.libcamera.org/series/923/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3840/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3840/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B680603D7\n\tfor ;\n\tFri, 22 May 2020 16:55:19 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 19A46528\n\tfor ;\n\tFri, 22 May 2020 16:55:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"h3WawItl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1590159319;\n\tbh=fUcZv2BHrO81ER5WBhyLOJ756arZ1hinkUqNxKjLMmM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=h3WawItlS3jiWxZJPbXx1GLf6pX14II1T6kWpfVM5Ipn8cHeQxL6DvR9f8kuk012o\n\tmnkXZ3HpvReJqMnJmfTLlIU2xssyTSJVIuJ+A4J8umQ7eKePxfJ53i9r1kM+qXWAjK\n\tK6NV/5547hVgh0XUWWQ/8FoHX/jRa14RxLo1I5Ak=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 22 May 2020 17:54:48 +0300","Message-Id":"<20200522145459.16836-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.26.2","In-Reply-To":"<20200522145459.16836-1-laurent.pinchart@ideasonboard.com>","References":"<20200522145459.16836-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH/RFC 01/11] libcamera: Rename\n\tpixelformats.{cpp, h} to pixel_format.{cpp, h}","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 22 May 2020 14:55:19 -0000"},"content":"The libcamera source files are named after class names, using\nsnake_case. pixelformats.h and pixelformats.cpp don't comply with that\nrule. Fix them.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/formats.h | 2 +-\n include/libcamera/internal/v4l2_pixelformat.h | 2 +-\n include/libcamera/internal/v4l2_videodevice.h | 2 +-\n include/libcamera/meson.build | 2 +-\n include/libcamera/{pixelformats.h => pixel_format.h} | 8 ++++----\n include/libcamera/stream.h | 2 +-\n src/libcamera/meson.build | 2 +-\n src/libcamera/pipeline/simple/converter.h | 2 +-\n src/libcamera/{pixelformats.cpp => pixel_format.cpp} | 8 ++++----\n src/libcamera/v4l2_pixelformat.cpp | 2 +-\n src/qcam/format_converter.h | 2 +-\n src/qcam/viewfinder.h | 2 +-\n 12 files changed, 18 insertions(+), 18 deletions(-)\n rename include/libcamera/{pixelformats.h => pixel_format.h} (82%)\n rename src/libcamera/{pixelformats.cpp => pixel_format.cpp} (95%)","diff":"diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\nindex 4092a93ef973..4455b0f9b050 100644\n--- a/include/libcamera/internal/formats.h\n+++ b/include/libcamera/internal/formats.h\n@@ -12,7 +12,7 @@\n #include \n \n #include \n-#include \n+#include \n \n #include \"libcamera/internal/v4l2_pixelformat.h\"\n \ndiff --git a/include/libcamera/internal/v4l2_pixelformat.h b/include/libcamera/internal/v4l2_pixelformat.h\nindex 0fe8a017de34..4d0e034b8b51 100644\n--- a/include/libcamera/internal/v4l2_pixelformat.h\n+++ b/include/libcamera/internal/v4l2_pixelformat.h\n@@ -13,7 +13,7 @@\n \n #include \n \n-#include \n+#include \n \n namespace libcamera {\n \ndiff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\nindex dc259523599c..c93cf816373b 100644\n--- a/include/libcamera/internal/v4l2_videodevice.h\n+++ b/include/libcamera/internal/v4l2_videodevice.h\n@@ -17,7 +17,7 @@\n \n #include \n #include \n-#include \n+#include \n #include \n \n #include \"libcamera/internal/formats.h\"\ndiff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex 27760c19f9b9..73c5b999acf4 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -13,7 +13,7 @@ libcamera_public_headers = files([\n 'geometry.h',\n 'logging.h',\n 'object.h',\n- 'pixelformats.h',\n+ 'pixel_format.h',\n 'request.h',\n 'signal.h',\n 'span.h',\ndiff --git a/include/libcamera/pixelformats.h b/include/libcamera/pixel_format.h\nsimilarity index 82%\nrename from include/libcamera/pixelformats.h\nrename to include/libcamera/pixel_format.h\nindex 89966e5e664c..e3b371ef92bb 100644\n--- a/include/libcamera/pixelformats.h\n+++ b/include/libcamera/pixel_format.h\n@@ -2,10 +2,10 @@\n /*\n * Copyright (C) 2019, Google Inc.\n *\n- * pixelformats.h - libcamera pixel formats\n+ * pixel_format.h - libcamera Pixel Format\n */\n-#ifndef __LIBCAMERA_PIXEL_FORMATS_H__\n-#define __LIBCAMERA_PIXEL_FORMATS_H__\n+#ifndef __LIBCAMERA_PIXEL_FORMAT_H__\n+#define __LIBCAMERA_PIXEL_FORMAT_H__\n \n #include \n #include \n@@ -40,4 +40,4 @@ private:\n \n } /* namespace libcamera */\n \n-#endif /* __LIBCAMERA_PIXEL_FORMATS_H__ */\n+#endif /* __LIBCAMERA_PIXEL_FORMAT_H__ */\ndiff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex b3cbea3d5229..1a68bd23a81a 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -14,7 +14,7 @@\n \n #include \n #include \n-#include \n+#include \n \n namespace libcamera {\n \ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex b88f295d251d..611fc061e1cf 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -34,7 +34,7 @@ libcamera_sources = files([\n 'message.cpp',\n 'object.cpp',\n 'pipeline_handler.cpp',\n- 'pixelformats.cpp',\n+ 'pixel_format.cpp',\n 'process.cpp',\n 'pub_key.cpp',\n 'request.cpp',\ndiff --git a/src/libcamera/pipeline/simple/converter.h b/src/libcamera/pipeline/simple/converter.h\nindex 1f770eb844b5..ef18cf73a2ed 100644\n--- a/src/libcamera/pipeline/simple/converter.h\n+++ b/src/libcamera/pipeline/simple/converter.h\n@@ -12,7 +12,7 @@\n #include \n #include \n \n-#include \n+#include \n #include \n \n namespace libcamera {\ndiff --git a/src/libcamera/pixelformats.cpp b/src/libcamera/pixel_format.cpp\nsimilarity index 95%\nrename from src/libcamera/pixelformats.cpp\nrename to src/libcamera/pixel_format.cpp\nindex 1330dc5ab3d9..d8718739152d 100644\n--- a/src/libcamera/pixelformats.cpp\n+++ b/src/libcamera/pixel_format.cpp\n@@ -2,14 +2,14 @@\n /*\n * Copyright (C) 2019, Google Inc.\n *\n- * pixelformats.cpp - libcamera pixel formats\n+ * pixel_format.cpp - libcamera Pixel Format\n */\n \n-#include \n+#include \n \n /**\n- * \\file pixelformats.h\n- * \\brief libcamera pixel formats\n+ * \\file pixel_format.h\n+ * \\brief libcamera pixel format\n */\n \n namespace libcamera {\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 36776be99e59..94fae470f926 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -14,7 +14,7 @@\n \n #include \n \n-#include \n+#include \n \n #include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/log.h\"\ndiff --git a/src/qcam/format_converter.h b/src/qcam/format_converter.h\nindex 5e28adf0ef63..e389b24a69f7 100644\n--- a/src/qcam/format_converter.h\n+++ b/src/qcam/format_converter.h\n@@ -11,7 +11,7 @@\n \n #include \n \n-#include \n+#include \n \n class QImage;\n \ndiff --git a/src/qcam/viewfinder.h b/src/qcam/viewfinder.h\nindex b3f1d25d9d60..26a1320537d2 100644\n--- a/src/qcam/viewfinder.h\n+++ b/src/qcam/viewfinder.h\n@@ -17,7 +17,7 @@\n #include \n \n #include \n-#include \n+#include \n \n #include \"format_converter.h\"\n \n","prefixes":["libcamera-devel","PATCH/RFC","01/11"]}