{"id":3813,"url":"https://patchwork.libcamera.org/api/1.1/patches/3813/?format=json","web_url":"https://patchwork.libcamera.org/patch/3813/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200519032505.17307-3-laurent.pinchart@ideasonboard.com>","date":"2020-05-19T03:24:59","name":"[libcamera-devel,2/8] cam: Add FrameSink base class","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"507e47d3f2a65866eed4e262a7aafaaf0ddcc964","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/3813/mbox/","series":[{"id":912,"url":"https://patchwork.libcamera.org/api/1.1/series/912/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=912","date":"2020-05-19T03:24:57","name":"libcamera: Add DRM/KMS viewfinder display to cam","version":1,"mbox":"https://patchwork.libcamera.org/series/912/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3813/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3813/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3575D60E44\n\tfor ;\n\tTue, 19 May 2020 05:25:19 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA87D30C\n\tfor ;\n\tTue, 19 May 2020 05:25:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LszftT3t\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589858719;\n\tbh=f1jXq/4rvugginWdAETolbk2dXRKTvSR11MQj/WFbu8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=LszftT3tAQAvyDCTJK6JHG0ZVQJEYAEElk6vOcS7y2buX1j8BtNcA/DL+QuvMz/Y2\n\tk7hMf2BYXcOspSg308k74WVcmkOzd4KBzDJG/bXuzmPENjx6ikei5JVcRoT+d9gnjI\n\t3ffI5Zoj2tugGs59zIQs+UmECJ+I8BQLYuWbT4Hc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 19 May 2020 06:24:59 +0300","Message-Id":"<20200519032505.17307-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.26.2","In-Reply-To":"<20200519032505.17307-1-laurent.pinchart@ideasonboard.com>","References":"<20200519032505.17307-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/8] cam: Add FrameSink base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 19 May 2020 03:25:20 -0000"},"content":"The FrameSink class serves as a base to implement components that\nconsume frames. This allows handling frame sinks in a generic way,\nindependent of their nature. The BufferWrite class will be ported to\nFrameSink in a second step.\n\nSigned-off-by: Laurent Pinchart \n---\n src/cam/frame_sink.cpp | 31 +++++++++++++++++++++++++++++++\n src/cam/frame_sink.h | 35 +++++++++++++++++++++++++++++++++++\n src/cam/meson.build | 1 +\n 3 files changed, 67 insertions(+)\n create mode 100644 src/cam/frame_sink.cpp\n create mode 100644 src/cam/frame_sink.h","diff":"diff --git a/src/cam/frame_sink.cpp b/src/cam/frame_sink.cpp\nnew file mode 100644\nindex 000000000000..fbe16e2f5081\n--- /dev/null\n+++ b/src/cam/frame_sink.cpp\n@@ -0,0 +1,31 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2020, Ideas on Board Oy\n+ *\n+ * frame_sink.cpp - Base Frame Sink Class\n+ */\n+\n+#include \"frame_sink.h\"\n+\n+FrameSink::~FrameSink()\n+{\n+}\n+\n+int FrameSink::configure(const libcamera::CameraConfiguration &config)\n+{\n+\treturn 0;\n+}\n+\n+void FrameSink::mapBuffer(libcamera::FrameBuffer *buffer)\n+{\n+}\n+\n+int FrameSink::start()\n+{\n+\treturn 0;\n+}\n+\n+int FrameSink::stop()\n+{\n+\treturn 0;\n+}\ndiff --git a/src/cam/frame_sink.h b/src/cam/frame_sink.h\nnew file mode 100644\nindex 000000000000..39604a07eb70\n--- /dev/null\n+++ b/src/cam/frame_sink.h\n@@ -0,0 +1,35 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2020, Ideas on Board Oy\n+ *\n+ * frame_sink.h - Base Frame Sink Class\n+ */\n+#ifndef __CAM_FRAME_SINK_H__\n+#define __CAM_FRAME_SINK_H__\n+\n+#include \n+\n+namespace libcamera {\n+class CameraConfiguration;\n+class FrameBuffer;\n+class Stream;\n+} /* namespace libcamera */\n+\n+class FrameSink\n+{\n+public:\n+\tvirtual ~FrameSink();\n+\n+\tvirtual int configure(const libcamera::CameraConfiguration &config);\n+\n+\tvirtual void mapBuffer(libcamera::FrameBuffer *buffer);\n+\n+\tvirtual int start();\n+\tvirtual int stop();\n+\n+\tvirtual bool consumeBuffer(const libcamera::Stream *stream,\n+\t\t\t\t libcamera::FrameBuffer *buffer) = 0;\n+\tlibcamera::Signal bufferReleased;\n+};\n+\n+#endif /* __CAM_FRAME_SINK_H__ */\ndiff --git a/src/cam/meson.build b/src/cam/meson.build\nindex 89e124fbae2a..d7b72ec02f8c 100644\n--- a/src/cam/meson.build\n+++ b/src/cam/meson.build\n@@ -4,6 +4,7 @@ cam_sources = files([\n 'buffer_writer.cpp',\n 'capture.cpp',\n 'event_loop.cpp',\n+ 'frame_sink.cpp',\n 'main.cpp',\n 'options.cpp',\n 'stream_options.cpp',\n","prefixes":["libcamera-devel","2/8"]}