{"id":3773,"url":"https://patchwork.libcamera.org/api/1.1/patches/3773/?format=json","web_url":"https://patchwork.libcamera.org/patch/3773/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200512000322.11753-20-laurent.pinchart@ideasonboard.com>","date":"2020-05-12T00:03:17","name":"[libcamera-devel,19/24] utils: raspberrypi: ctt: Fix pycodestyle E721","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"eea58ba61905065bb8bbfa819d19425c2768df32","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3773/mbox/","series":[{"id":897,"url":"https://patchwork.libcamera.org/api/1.1/series/897/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=897","date":"2020-05-12T00:02:58","name":"utils: raspberrypi: ctt: Comply with pycodestyle","version":1,"mbox":"https://patchwork.libcamera.org/series/897/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3773/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3773/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7459D60DF9\n\tfor ;\n\tTue, 12 May 2020 02:03:46 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7510A120C;\n\tTue, 12 May 2020 02:03:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pNAU1OaQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589241825;\n\tbh=MxoezXKaj0RqpeUNTZK99ziqfV4jkAWx+EoWQz+B/dk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pNAU1OaQHdW7Ja2TwXAUo9bfvIvIqLlyCCucRtIkRkcxwXun7Q+jIrooHWCO+l4sK\n\t28RbDSu6x0Puo1wjaQbIQaDdnmIPGA8eFr8tXeTYNJ9X+1tqtNBgAvfhZVLrQA+MLl\n\tysWXfdn5ADkb4OOHFcE2qOxc5xeVZlvvvNfBnevU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 12 May 2020 03:03:17 +0300","Message-Id":"<20200512000322.11753-20-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.26.2","In-Reply-To":"<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>","References":"<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 19/24] utils: raspberrypi: ctt: Fix\n\tpycodestyle E721","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 12 May 2020 00:03:46 -0000"},"content":"E721 do not compare types, use 'isinstance()'\n\nSigned-off-by: Laurent Pinchart \n---\n utils/raspberrypi/ctt/ctt_tools.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/utils/raspberrypi/ctt/ctt_tools.py b/utils/raspberrypi/ctt/ctt_tools.py\nindex f4b9baac5521..3a2fb4af95c5 100644\n--- a/utils/raspberrypi/ctt/ctt_tools.py\n+++ b/utils/raspberrypi/ctt/ctt_tools.py\n@@ -36,10 +36,10 @@ def get_config(dictt, key, default, ttype):\n if 'float' not in str(type(val)):\n raise ValueError\n elif ttype == 'dict':\n- if type(val) != type(dictt):\n+ if not isinstance(val, dict):\n raise ValueError\n elif ttype == 'list':\n- if type(val) != type([]):\n+ if not isinstance(val, list):\n raise ValueError\n elif ttype == 'bool':\n ttype = int(bool(ttype))\n","prefixes":["libcamera-devel","19/24"]}