{"id":3690,"url":"https://patchwork.libcamera.org/api/1.1/patches/3690/?format=json","web_url":"https://patchwork.libcamera.org/patch/3690/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200506103346.3433-3-email@uajain.com>","date":"2020-05-06T10:33:53","name":"[libcamera-devel,2/4] libcamera: camera_manager: Introduce signals when a camera is added/removed","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"430cd28e8f640e6e04a70433b183247714d1364e","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3690/mbox/","series":[{"id":881,"url":"https://patchwork.libcamera.org/api/1.1/series/881/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=881","date":"2020-05-06T10:33:51","name":"Introduce UVC hotplug support","version":1,"mbox":"https://patchwork.libcamera.org/series/881/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3690/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3690/checks/","tags":{},"headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B32561698\n\tfor ;\n\tWed, 6 May 2020 12:33:55 +0200 (CEST)","by filter0081p3las1.sendgrid.net with SMTP id\n\tfilter0081p3las1-3357-5EB29290-F2\n\t2020-05-06 10:33:53.206528954 +0000 UTC m=+1773122.500703768","from mail.uajain.com (unknown)\n\tby ismtpd0005p1maa1.sendgrid.net (SG) with ESMTP id\n\tIxvEqa3mSwma1nYmOmTIdA for ;\n\tWed, 06 May 2020 10:33:52.840 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"Rbyg+v+M\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=B5Jbb3/CjZ/78+Unt8jaSzv4o2LgeBkW6IhXGg6FNiM=;\n\tb=Rbyg+v+MVnjP6E26/cUJGvt6VkfTJR7q7GzmTDJklpDuWM4mtit5fKQ4zig/FENUbOhR\n\tZFg+R06jefX8OOA98cF2wpfrZOAklCkKtIhOL5qP40OpdiGdbvjVGZzb2rkceHIDuF5mzb\n\tRT2UpUmOrrUGLZkh0yt/Qgz3D22hbUUSI=","From":"Umang Jain ","Date":"Wed, 06 May 2020 10:33:53 +0000 (UTC)","Message-Id":"<20200506103346.3433-3-email@uajain.com>","In-Reply-To":"<20200506103346.3433-1-email@uajain.com>","References":"<20200506103346.3433-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc8Y1sFjEEckHl5AFRmKDueraXKxp573m8sSCEK90OLFw+qYpEOzFFN3Mh07YU/WWy7V3S2jEqv8pKCFA8dL0JHiS15q++nMXIZNSnz/i8DTPT2nRhPWgM/8fcYtsFJOiZ5uB19qoUfJ+cyASB2+HIXQ/0UzG+h3YPY72YC6fu+/sqIiBWEQiA/kNHLALC+j+e","To":"libcamera-devel ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH 2/4] libcamera: camera_manager: Introduce\n\tsignals when a camera is added/removed","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 06 May 2020 10:33:55 -0000"},"content":"Emit 'cameraAdded' and 'cameraRemoved' from CameraManager to enable\nhotplug and hot-unplug support in appplications like QCam.\n\nSigned-off-by: Umang Jain \n---\n include/libcamera/camera_manager.h | 4 ++++\n src/libcamera/camera_manager.cpp | 20 ++++++++++++++++++++\n 2 files changed, 24 insertions(+)","diff":"diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\nindex 079f848..558bb96 100644\n--- a/include/libcamera/camera_manager.h\n+++ b/include/libcamera/camera_manager.h\n@@ -13,6 +13,7 @@\n #include \n \n #include \n+#include \n \n namespace libcamera {\n \n@@ -42,6 +43,9 @@ public:\n \tvoid setEventDispatcher(std::unique_ptr dispatcher);\n \tEventDispatcher *eventDispatcher();\n \n+\tSignal cameraAdded;\n+\tSignal cameraRemoved;\n+\n private:\n \tstatic const std::string version_;\n \tstatic CameraManager *self_;\ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex c75979a..6438f87 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -391,6 +391,23 @@ std::shared_ptr CameraManager::get(dev_t devnum)\n \treturn iter->second.lock();\n }\n \n+/**\n+ * \\var CameraManager::cameraAdded\n+ * \\brief Signal emitted when a new camera is added in CameraManager\n+ *\n+ * This signal is emitted when a new camera is added by the CameraManager\n+ * in the list of cameras it manages. A pointer to the newly-added camera\n+ * is passed as a parameter.\n+ */\n+\n+/**\n+ * \\var CameraManager::cameraRemoved\n+ * \\brief Signal emitted when a camera is removed in CameraManager\n+ *\n+ * This signal is emitted when a camera is removed from the CameraManager.\n+ * A pointer to the removed camera is passed as a parameter.\n+ */\n+\n /**\n * \\brief Add a camera to the camera manager\n * \\param[in] camera The camera to be added\n@@ -409,7 +426,9 @@ void CameraManager::addCamera(std::shared_ptr camera, dev_t devnum)\n {\n \tASSERT(Thread::current() == p_.get());\n \n+\tCamera *cam = camera.get();\n \tp_->addCamera(camera, devnum);\n+\tcameraAdded.emit(cam);\n }\n \n /**\n@@ -427,6 +446,7 @@ void CameraManager::removeCamera(Camera *camera)\n \tASSERT(Thread::current() == p_.get());\n \n \tp_->removeCamera(camera);\n+\tcameraRemoved.emit(camera);\n }\n \n /**\n","prefixes":["libcamera-devel","2/4"]}