{"id":3677,"url":"https://patchwork.libcamera.org/api/1.1/patches/3677/?format=json","web_url":"https://patchwork.libcamera.org/patch/3677/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200503002723.1367196-1-niklas.soderlund@ragnatech.se>","date":"2020-05-03T00:27:23","name":"[libcamera-devel] qcam: dng_writer: Remove colon from \\todo","commit_ref":"f5698ed541a424befa7258ecb459ec44e406fdb5","pull_url":null,"state":"accepted","archived":false,"hash":"c14652104bd7e150a19a32b4e0dc9a25c154c263","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3677/mbox/","series":[{"id":875,"url":"https://patchwork.libcamera.org/api/1.1/series/875/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=875","date":"2020-05-03T00:27:23","name":"[libcamera-devel] qcam: dng_writer: Remove colon from \\todo","version":1,"mbox":"https://patchwork.libcamera.org/series/875/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3677/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3677/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5D7E603F4\n\tfor ;\n\tSun, 3 May 2020 02:27:30 +0200 (CEST)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid da0f2b19-8cd4-11ea-89d0-0050569116f7;\n\tSun, 03 May 2020 02:27:25 +0200 (CEST)"],"X-Halon-ID":"da0f2b19-8cd4-11ea-89d0-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 3 May 2020 02:27:23 +0200","Message-Id":"<20200503002723.1367196-1-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.26.2","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] qcam: dng_writer: Remove colon from \\todo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 03 May 2020 00:27:31 -0000"},"content":"Todo statements should not end with a colon, remove it.\n\nSigned-off-by: Niklas Söderlund \n---\n src/qcam/dng_writer.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\nindex 7d51965dc2ea3201..f0d6f5f473e3d680 100644\n--- a/src/qcam/dng_writer.cpp\n+++ b/src/qcam/dng_writer.cpp\n@@ -47,7 +47,7 @@ void packScanlineSBGGR12P(void *output, const void *input, unsigned int width)\n \tconst uint8_t *in = static_cast(input);\n \tuint8_t *out = static_cast(output);\n \n-\t/* \\todo: Can this be made more efficient? */\n+\t/* \\todo Can this be made more efficient? */\n \tfor (unsigned int i = 0; i < width; i += 2) {\n \t\t*out++ = in[0];\n \t\t*out++ = (in[2] & 0x0f) << 4 | in[1] >> 4;\n","prefixes":["libcamera-devel"]}