{"id":3673,"url":"https://patchwork.libcamera.org/api/1.1/patches/3673/?format=json","web_url":"https://patchwork.libcamera.org/patch/3673/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200502225704.2911-3-laurent.pinchart@ideasonboard.com>","date":"2020-05-02T22:57:01","name":"[libcamera-devel,2/5] qcam: dng_writer: Name arguments to packScanline()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"413f131e71a25e7c2a3fbae766040281e926a59b","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3673/mbox/","series":[{"id":874,"url":"https://patchwork.libcamera.org/api/1.1/series/874/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=874","date":"2020-05-02T22:56:59","name":"qcam: Improve DNG writer","version":1,"mbox":"https://patchwork.libcamera.org/series/874/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3673/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3673/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 620796162E\n\tfor ;\n\tSun, 3 May 2020 00:57:11 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B207521\n\tfor ;\n\tSun, 3 May 2020 00:57:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YUDiKhqP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588460231;\n\tbh=wzQtGrsiDCZBzEFWkssCYnZH/nvfajppgb4PpeXrX5M=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=YUDiKhqPRsKSUWir5tey7Y5YgO++BwbYUTVB9PsxtB3FEAfM1asyKArCnkqzEBJgr\n\tc9YcaNA9oPFbli+bM3CdOtmj4iwlgHK+Kic9iiaLJSbIozIO2+MYH74xUD6txXuR4s\n\twzbdzOwopqAMuCOOx2/1P9j6TTgmisXvG5uWSTus=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 3 May 2020 01:57:01 +0300","Message-Id":"<20200502225704.2911-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.25.3","In-Reply-To":"<20200502225704.2911-1-laurent.pinchart@ideasonboard.com>","References":"<20200502225704.2911-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/5] qcam: dng_writer: Name arguments to\n\tpackScanline()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 02 May 2020 22:57:11 -0000"},"content":"Name arguments to the FormatInfo::packScanline function pointer to make\nit easier to understand its usage when reading the function declaration.\n\nSigned-off-by: Laurent Pinchart \n---\n src/qcam/dng_writer.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\nindex b1984c6647dd..d5270323abd4 100644\n--- a/src/qcam/dng_writer.cpp\n+++ b/src/qcam/dng_writer.cpp\n@@ -23,7 +23,8 @@ enum CFAPatternColour : uint8_t {\n struct FormatInfo {\n \tuint8_t bitsPerSample;\n \tCFAPatternColour pattern[4];\n-\tvoid (*packScanline)(void *, const void *, unsigned int);\n+\tvoid (*packScanline)(void *output, const void *input,\n+\t\t\t unsigned int width);\n };\n \n void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n","prefixes":["libcamera-devel","2/5"]}