{"id":3563,"url":"https://patchwork.libcamera.org/api/1.1/patches/3563/?format=json","web_url":"https://patchwork.libcamera.org/patch/3563/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200427031713.14013-12-laurent.pinchart@ideasonboard.com>","date":"2020-04-27T03:17:13","name":"[libcamera-devel,11/11] ipa: vimc: Validate configuration file in init()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c7cb5b0d4f1486e7ed50e1ef2808f9527cde2056","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3563/mbox/","series":[{"id":831,"url":"https://patchwork.libcamera.org/api/1.1/series/831/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=831","date":"2020-04-27T03:17:02","name":"libcamera: Add support for IPA configuration","version":1,"mbox":"https://patchwork.libcamera.org/series/831/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3563/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3563/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E04EB61212\n\tfor ;\n\tMon, 27 Apr 2020 05:17:36 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FAF672C\n\tfor ;\n\tMon, 27 Apr 2020 05:17:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"d3MHoxbY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587957456;\n\tbh=L/Id3vhye5F7dVlO7V/6uEru7Nw+QzFKHtGenNJ4v/A=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=d3MHoxbYWCUUdYbcebOsvdg2vxWiLIRRpOtgu9oUyF93/ZQcX5sAfSbFWWo9gs0Vm\n\tM4/F4FmXFaUQAktjwcVK0z9utbR+ULE9SYtr5BLtiYnThiSu8vhBlygf3P416XJom1\n\tgdpWnM6AR/aBlHUE+SNol03QNXWpBmjwRCJVv5qo=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 27 Apr 2020 06:17:13 +0300","Message-Id":"<20200427031713.14013-12-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.25.3","In-Reply-To":"<20200427031713.14013-1-laurent.pinchart@ideasonboard.com>","References":"<20200427031713.14013-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 11/11] ipa: vimc: Validate configuration\n\tfile in init()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 Apr 2020 03:17:39 -0000"},"content":"Make sure we can open the configuration file passed to the init()\nfunction, and return an error otherwise.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/vimc/vimc.cpp | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex e6bda8ec58b0..f29bc504d8c8 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -19,6 +19,7 @@\n \n #include \n \n+#include \"file.h\"\n #include \"log.h\"\n \n namespace libcamera {\n@@ -65,7 +66,15 @@ int IPAVimc::init(const IPASettings &settings)\n {\n \ttrace(IPAOperationInit);\n \n-\tLOG(IPAVimc, Debug) << \"initializing vimc IPA!\";\n+\tLOG(IPAVimc, Debug)\n+\t\t<< \"initializing vimc IPA with configuration file \"\n+\t\t<< settings.configurationFile;\n+\n+\tFile conf(settings.configurationFile);\n+\tif (!conf.open(File::ReadOnly)) {\n+\t\tLOG(IPAVimc, Error) << \"Failed to open configuration file\";\n+\t\treturn -EINVAL;\n+\t}\n \n \treturn 0;\n }\n","prefixes":["libcamera-devel","11/11"]}