{"id":3543,"url":"https://patchwork.libcamera.org/api/1.1/patches/3543/?format=json","web_url":"https://patchwork.libcamera.org/patch/3543/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200425205639.30566-2-laurent.pinchart@ideasonboard.com>","date":"2020-04-25T20:56:39","name":"[libcamera-devel,2/2,DNI] test: Test serialization of Rectangle and Size controls","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"89a66c600afbd56b1f91eb1639a62476013f0f54","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/3543/mbox/","series":[{"id":825,"url":"https://patchwork.libcamera.org/api/1.1/series/825/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=825","date":"2020-04-25T20:56:38","name":"[libcamera-devel,1/2] libcamera: controls: Add rectangle and size control types","version":1,"mbox":"https://patchwork.libcamera.org/series/825/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3543/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3543/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B00DF62E55\n\tfor ;\n\tSat, 25 Apr 2020 22:56:59 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B015564;\n\tSat, 25 Apr 2020 22:56:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"W60XNR2b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587848219;\n\tbh=vhWaM15xgjS3IHFmWEkHWTr0/iGBGgVlT8pxyKQ2/6Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=W60XNR2b6XVydXGRAYYkwejvUo0/HwUgm78XVXvwNfOghix8aOZ4ERoGfFEtZ7wUR\n\ttQUgNwyIqlPtO13UqGvrJwHWEwd6208jL7yEj0uQtbG8YaxGdt4NfhV95Fjy8odA2u\n\tj6zOBBVtFj+lZMAuX4kwPgtv5ty2NXk0im3koFA4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 25 Apr 2020 23:56:39 +0300","Message-Id":"<20200425205639.30566-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.25.3","In-Reply-To":"<20200425205639.30566-1-laurent.pinchart@ideasonboard.com>","References":"<20200425205639.30566-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] [DNI] test: Test serialization of\n\tRectangle and Size controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 25 Apr 2020 20:56:59 -0000"},"content":"This patch should be rebased on real controls once available.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/control_ids.yaml | 18 ++++++++++++++++++\n test/serialization/control_serialization.cpp | 5 +++++\n 2 files changed, 23 insertions(+)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 4befec746a59..b1ae03e5b0ff 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -50,4 +50,22 @@ controls:\n type: int32_t\n description: Specify a fixed gain parameter\n \n+ - TheRectangle:\n+ type: Rectangle\n+ description: A Rectangle property\n+\n+ - TheRectangles:\n+ type: Rectangle\n+ description: A Rectangle array property\n+ size: [n]\n+\n+ - TheSize:\n+ type: Size\n+ description: A Size property\n+\n+ - TheSizes:\n+ type: Size\n+ description: A Size array property\n+ size: [n]\n+\n ...\ndiff --git a/test/serialization/control_serialization.cpp b/test/serialization/control_serialization.cpp\nindex 2989b52774fb..789e0d83f4e4 100644\n--- a/test/serialization/control_serialization.cpp\n+++ b/test/serialization/control_serialization.cpp\n@@ -45,6 +45,11 @@ protected:\n \t\tlist.set(controls::Brightness, 255);\n \t\tlist.set(controls::Contrast, 128);\n \t\tlist.set(controls::Saturation, 50);\n+\t\tlist.set(controls::TheRectangle, Rectangle{ 100, 100, 640, 480 });\n+\t\tlist.set(controls::TheRectangles, { Rectangle{ 100, 100, 640, 480 },\n+\t\t\t\t\t\t Rectangle{ 200, 200, 1280, 720 } });\n+\t\tlist.set(controls::TheSize, Size{ 640, 480 });\n+\t\tlist.set(controls::TheSizes, { Size{ 640, 480 }, Size{ 1280, 720 } });\n \n \t\t/*\n \t\t * Serialize the control list, this should fail as the control\n","prefixes":["libcamera-devel","2/2","DNI"]}