{"id":3537,"url":"https://patchwork.libcamera.org/api/1.1/patches/3537/?format=json","web_url":"https://patchwork.libcamera.org/patch/3537/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200425004533.26907-4-laurent.pinchart@ideasonboard.com>","date":"2020-04-25T00:45:29","name":"[libcamera-devel,v5,3/7] libcamera: control_ids: Add comment to specify control direction","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"05e096638d4574ebe31f32fbdfcbbc47dd2a5ffc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3537/mbox/","series":[{"id":824,"url":"https://patchwork.libcamera.org/api/1.1/series/824/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=824","date":"2020-04-25T00:45:26","name":"Patchset for libcamera controls","version":5,"mbox":"https://patchwork.libcamera.org/series/824/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3537/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3537/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D12462E45\n\tfor ;\n\tSat, 25 Apr 2020 02:45:53 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DCE27DAD;\n\tSat, 25 Apr 2020 02:45:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MgpH4N9b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587775553;\n\tbh=BX8EnDSYZidO11p66DGz/BVxNd8Tm7yk+F1W2wGxoZc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MgpH4N9bc0klcgYDdCCm/xRN/0GONeE5uZ0kN3IUKot18w5bVvetLofQf661SCVHG\n\tXbX9RUebpzCLZfM97m/Q8a1OBI6zaTVGFIQ3obqTjKF5hZnanM1f1bRuAA+//tbm4i\n\tpR3BVuObXn1DFZb4au/11pbzOVzuixOhDhu5Tl9E=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 25 Apr 2020 03:45:29 +0300","Message-Id":"<20200425004533.26907-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.25.3","In-Reply-To":"<20200425004533.26907-1-laurent.pinchart@ideasonboard.com>","References":"<20200425004533.26907-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 3/7] libcamera: control_ids: Add\n\tcomment to specify control direction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 25 Apr 2020 00:45:53 -0000"},"content":"From: Naushir Patuck \n\nDocument that controls are bi-directional by default. If a control\nis only returned in metadata, this must be specified in the control's\ndescription.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Laurent Pinchart \nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/control_ids.cpp.in | 3 +++\n src/libcamera/control_ids.yaml | 2 ++\n 2 files changed, 5 insertions(+)","diff":"diff --git a/src/libcamera/control_ids.cpp.in b/src/libcamera/control_ids.cpp.in\nindex 99c511d0e712..cba6258d68dd 100644\n--- a/src/libcamera/control_ids.cpp.in\n+++ b/src/libcamera/control_ids.cpp.in\n@@ -33,6 +33,9 @@ ${controls_def}\n \n /**\n * \\brief List of all supported libcamera controls\n+ *\n+ * Unless otherwise stated, all controls are bi-directional, i.e. they can be\n+ * set through Request::controls() and returned out through Request::metadata().\n */\n extern const ControlIdMap controls {\n ${controls_map}\ndiff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 4befec746a59..bcbab195a374 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -4,6 +4,8 @@\n #\n %YAML 1.2\n ---\n+# Unless otherwise stated, all controls are bi-directional, i.e. they can be\n+# set through Request::controls() and returned out through Request::metadata().\n controls:\n - AeEnable:\n type: bool\n","prefixes":["libcamera-devel","v5","3/7"]}