{"id":3530,"url":"https://patchwork.libcamera.org/api/1.1/patches/3530/?format=json","web_url":"https://patchwork.libcamera.org/patch/3530/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200424215304.558317-13-jacopo@jmondi.org>","date":"2020-04-24T21:53:03","name":"[libcamera-devel,v3,12/13] libcamera: v4l2_device: Update documentation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a3838900e7233f656436bdfc67edeab7598a4858","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3530/mbox/","series":[{"id":822,"url":"https://patchwork.libcamera.org/api/1.1/series/822/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=822","date":"2020-04-24T21:52:51","name":"libcamera: Add CameraSensorInfo","version":3,"mbox":"https://patchwork.libcamera.org/series/822/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3530/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3530/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F38CB62E67\n\tfor ;\n\tFri, 24 Apr 2020 23:50:15 +0200 (CEST)","from uno.homenet.telecomitalia.it\n\t(host240-55-dynamic.3-87-r.retail.telecomitalia.it [87.3.55.240])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 56F0B60002;\n\tFri, 24 Apr 2020 21:50:15 +0000 (UTC)"],"X-Originating-IP":"87.3.55.240","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 24 Apr 2020 23:53:03 +0200","Message-Id":"<20200424215304.558317-13-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.26.1","In-Reply-To":"<20200424215304.558317-1-jacopo@jmondi.org>","References":"<20200424215304.558317-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 12/13] libcamera: v4l2_device: Update\n\tdocumentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 24 Apr 2020 21:50:16 -0000"},"content":"Compound controls are now supported, but they're still listed as\nunsupported in some parts of the V4L2Device class documentation.\nFix this by removing those parts.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/v4l2_device.cpp | 19 +++++++++----------\n 1 file changed, 9 insertions(+), 10 deletions(-)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 9d67e0f63b1e..da7eb2bc5849 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -153,9 +153,9 @@ void V4L2Device::close()\n * their values in the corresponding \\a ctrls entry.\n *\n * If any control in \\a ctrls is not supported by the device, is disabled (i.e.\n- * has the V4L2_CTRL_FLAG_DISABLED flag set), is a compound control, or if any\n- * other error occurs during validation of the requested controls, no control is\n- * read and this method returns -EINVAL.\n+ * has the V4L2_CTRL_FLAG_DISABLED flag set), or if any other error occurs\n+ * during validation of the requested controls, no control is read and this\n+ * method returns -EINVAL.\n *\n * If an error occurs while reading the controls, the index of the first control\n * that couldn't be read is returned. The value of all controls below that index\n@@ -262,10 +262,9 @@ int V4L2Device::getControls(ControlList *ctrls)\n * \\a ctrls entry.\n *\n * If any control in \\a ctrls is not supported by the device, is disabled (i.e.\n- * has the V4L2_CTRL_FLAG_DISABLED flag set), is read-only, is a\n- * compound control, or if any other error occurs during validation of\n- * the requested controls, no control is written and this method returns\n- * -EINVAL.\n+ * has the V4L2_CTRL_FLAG_DISABLED flag set), is read-only, if any other error\n+ * occurs during validation of the requested controls, no control is written and\n+ * this method returns -EINVAL.\n *\n * If an error occurs while writing the controls, the index of the first\n * control that couldn't be written is returned. All controls below that index\n@@ -395,7 +394,7 @@ void V4L2Device::listControls()\n \tControlInfoMap::Map ctrls;\n \tstruct v4l2_query_ext_ctrl ctrl = {};\n \n-\t/* \\todo Add support for menu and compound controls. */\n+\t/* \\todo Add support for menu controls. */\n \twhile (1) {\n \t\tctrl.id |= V4L2_CTRL_FLAG_NEXT_CTRL |\n \t\t\t V4L2_CTRL_FLAG_NEXT_COMPOUND;\n@@ -468,8 +467,8 @@ void V4L2Device::updateControls(ControlList *ctrls,\n \n \t\tdefault:\n \t\t\t/*\n-\t\t\t * \\todo To be changed when support for string and\n-\t\t\t * compound controls will be added.\n+\t\t\t * \\todo To be changed when support for string controls\n+\t\t\t * will be added.\n \t\t\t */\n \t\t\tvalue.set(v4l2Ctrl->value);\n \t\t\tbreak;\n","prefixes":["libcamera-devel","v3","12/13"]}