{"id":3517,"url":"https://patchwork.libcamera.org/api/1.1/patches/3517/?format=json","web_url":"https://patchwork.libcamera.org/patch/3517/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200424104700.26819-6-naush@raspberrypi.com>","date":"2020-04-24T10:47:00","name":"[libcamera-devel,v4,5/5] libcamera: controls: Add AWB related controls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c764bd0c943479e0bd01a38be7914f54ff4acfb3","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3517/mbox/","series":[{"id":821,"url":"https://patchwork.libcamera.org/api/1.1/series/821/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=821","date":"2020-04-24T10:46:55","name":"Patchset for libcamera controls","version":4,"mbox":"https://patchwork.libcamera.org/series/821/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3517/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3517/checks/","tags":{},"headers":{"Return-Path":"<naush@raspberrypi.com>","Received":["from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AFABA62E67\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2020 12:47:16 +0200 (CEST)","by mail-wm1-x343.google.com with SMTP id k12so1353996wmj.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2020 03:47:16 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tj68sm7884997wrj.32.2020.04.24.03.47.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Apr 2020 03:47:15 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"o3LDMs+r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Rv0SdWrJ8b0yq+PQqecM3X8wUhY/bKbD8mhMLxv9GV0=;\n\tb=o3LDMs+rQwaHGBZ4Us38sytMkf7s8EHH5RhtsEMohWXJ4wHy+1gRMLQ3MNLkp6rBuS\n\tTod1DLT0o70CxKdqWsVgWMsm5QZ53N5/kYMr3WTFqRY1+6NXg1voQyumkRsdMYinyiqR\n\tUJ3DKUxUly1/3makWPOLWQqRTIMZEUhhmhKfb2Dt7HB2ajOMT8GjmEEf6rUB5KfnOjV8\n\tWa8hBWJpo/PPutbqlMaYMxPBEWUwsBuspys0n3RKAwr+cZPv6fYCAIwZ3Gl07blNByiZ\n\tdhSAStjr4/eJDmbl5aLlTzgxiVA7/Bq2eUJU7CNCIc7bhDNB1D7gXbWeyh9Lql/NAoOt\n\tP9Rg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Rv0SdWrJ8b0yq+PQqecM3X8wUhY/bKbD8mhMLxv9GV0=;\n\tb=WZwW1rKxmEO+lZzKy3Od9GI51xhjYCrUHjjD0hJsoFxja0xjB5p+03bChRAEGPIC1n\n\tLT4GcpX2biLmyZczvUdFOobxDyvoxFxJ+OyDqicIcgPUefvskQHh7xaNJ7F/Ev2NtQgu\n\t86r6vVxRvGBntv3EKjIRwcdltB8UNROUnx7HFPmSFZNkCEEccfZyGrsUINhZ7rMklklc\n\t20lujocP3uZbie8a9jFHGDJjjuyDl76g5xpTQsk9NR2k8+kc94ZgM6PV3iCTv+fsnDzM\n\tFTsGTFL1h4TAP8d1at6HCnKU3sCwR0DWCSJNdE8YppFFxM0zvyJUa4nMlPqKc0V5qoPz\n\tIHWw==","X-Gm-Message-State":"AGi0PubOn5+3ISgdkTlZR4vDkgzLTyOxYVt3ERvN16Nvn0HFcays124U\n\tWqXr1wLccj1sxwvQCiznu7GYwC3ESK5JxQ==","X-Google-Smtp-Source":"APiQypLT5AXrWwS9czPLLdjE3NcT+BHkKCee4/HmxMdz0NZ8J5mI446g2nYl0rnLNAKUaLgpKHVV6g==","X-Received":"by 2002:a7b:c14b:: with SMTP id z11mr9169431wmi.44.1587725236082;\n\tFri, 24 Apr 2020 03:47:16 -0700 (PDT)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 24 Apr 2020 11:47:00 +0100","Message-Id":"<20200424104700.26819-6-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20200424104700.26819-1-naush@raspberrypi.com>","References":"<20200424104700.26819-1-naush@raspberrypi.com>","Subject":"[libcamera-devel] [PATCH v4 5/5] libcamera: controls: Add AWB\n\trelated controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 24 Apr 2020 10:47:17 -0000"},"content":"AwbMode is a new enum type to specify operating mode of the AWB\nalgorithm. All modes may not be supported by all platforms.\n\nColourGains is a new float array type used to specify manual red\nand blue (in that order) colour channel gains when AWB is disabled.\n\nColourTemperature is a new control to return the current estimate of the\ncolour temperature.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 55 ++++++++++++++++++++++++++++++++++\n 1 file changed, 55 insertions(+)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex f66b851b..d922b039 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -169,6 +169,61 @@ controls:\n       description: |\n         Enable or disable the AWB.\n \n+        \\sa ColourGains\n+\n+  # AwbMode needs further attention:\n+  # - Auto-generate max enum value.\n+  # - Better handling of custom types.\n+  - AwbMode:\n+      type: int32_t\n+      description: |\n+        Specify the range of illuminants to use for the AWB algorithm. The modes\n+        supported are platform specific, and not all modes may be supported.\n+      enum:\n+        - name: AwbAuto\n+          value: 0\n+          description: Search over the whole colour temperature range.\n+        - name: AwbIncandescent\n+          value: 1\n+          description: Incandescent AWB lamp mode.\n+        - name: AwbTungsten\n+          value: 2\n+          description: Tungsten AWB lamp mode.\n+        - name: AwbFluorescent\n+          value: 3\n+          description: Fluorescent AWB lamp mode.\n+        - name: AwbIndoor\n+          value: 4\n+          description: Indoor AWB lighting mode.\n+        - name: AwbDaylight\n+          value: 5\n+          description: Daylight AWB lighting mode.\n+        - name: AwbCloudy\n+          value: 6\n+          description: Cloudy AWB lighting mode.\n+        - name: AwbCustom\n+          value: 7\n+          description: Custom AWB mode.\n+        - name: AwbModeMax\n+          value: 7\n+          description: Maximum allowed value (place any new values above here).\n+\n+  - ColourGains:\n+      type: float\n+      description: |\n+        Pair of gain values for the Red and Blue colour channels, in that\n+        order. ColourGains can only be applied in a Request when the AWB is\n+        disabled.\n+\n+        \\sa AwbEnable\n+      size: [2]\n+\n+  - ColourTemperature:\n+      type: float\n+      description: Report the current estimate of the colour temperature, in\n+        kelvin, for this frame. The ColourTemperature control can only be\n+        returned in metadata.\n+\n   - Saturation:\n       type: float\n       description:  |\n","prefixes":["libcamera-devel","v4","5/5"]}