{"id":3457,"url":"https://patchwork.libcamera.org/api/1.1/patches/3457/?format=json","web_url":"https://patchwork.libcamera.org/patch/3457/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200414070642.22366-2-email@uajain.com>","date":"2020-04-14T07:06:57","name":"[libcamera-devel,1/3] test: list-camera: Handle error on starting the CameraManager","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"771a7c1fd7c6a4aa7b57a41dc039638352e92aee","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3457/mbox/","series":[{"id":807,"url":"https://patchwork.libcamera.org/api/1.1/series/807/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=807","date":"2020-04-14T07:06:52","name":"More Coverity scans fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/807/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3457/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3457/checks/","tags":{},"headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0397462E31\n\tfor ;\n\tTue, 14 Apr 2020 09:06:58 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-sn8p2 with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-sn8p2-20-5E956111-26\n\t2020-04-14 07:06:57.432960553 +0000 UTC m=+1586563.220500062","from mail.uajain.com (unknown)\n\tby ismtpd0007p1hnd1.sendgrid.net (SG) with ESMTP\n\tid Xhih_PAwSjGBhw8mX9etdw Tue, 14 Apr 2020 07:06:57.100 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"iSxTdUz1\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=S+v4RAoVKLe0XvAFmWW4et8axI5VN1wdFf8ju951NJY=;\n\tb=iSxTdUz1TgP+ysEVXruFPMB7XJU7t2b770QIn7XISR6ckyCCYw+Xx1O7dZekGLrS9po9\n\t4dynmsh6TWU8bxV3Y3BrX7j+x2bDNUm2d69bvxq/+0YtB7vMUammyM0vBtzhru7WIZFdXB\n\tEDHAdbuVEWL/RMJ7wTYQbM7Z/HQm1fBJU=","From":"Umang Jain ","Date":"Tue, 14 Apr 2020 07:06:57 +0000 (UTC)","Message-Id":"<20200414070642.22366-2-email@uajain.com>","In-Reply-To":"<20200414070642.22366-1-email@uajain.com>","References":"<20200414070642.22366-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPclKwCK9CCZVFbQyNjpl2ex98oO3ds1tcaHYAc4KXlWkV6EnsjS/a9ug/U04JAxz/w6m84h2HfbnBI0v0uPgxxqMhsyvu1gH8g12/Ozjx0nFCqkAxwNQPxgIqXwqV71yIRMHbwsdpAfwJqg8mmKWGSd8BDHpxqf7UFDRIvhVnn/oh7hdPGYjHNZPVBljhL26wGmSCgy3Y2W+RMli+aqNHYCg==","To":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH 1/3] test: list-camera: Handle error on\n\tstarting the CameraManager","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 14 Apr 2020 07:06:59 -0000"},"content":"Pointed out by Coverity DefectId=297074\n\nSigned-off-by: Umang Jain \n---\n test/list-cameras.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/test/list-cameras.cpp b/test/list-cameras.cpp\nindex 55551d7..e6a407a 100644\n--- a/test/list-cameras.cpp\n+++ b/test/list-cameras.cpp\n@@ -21,7 +21,10 @@ protected:\n \tint init()\n \t{\n \t\tcm_ = new CameraManager();\n-\t\tcm_->start();\n+\t\tif (cm_->start()) {\n+\t\t\tstd::cout << \"Failed to start camera\" << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n \n \t\treturn 0;\n \t}\n","prefixes":["libcamera-devel","1/3"]}