{"id":3434,"url":"https://patchwork.libcamera.org/api/1.1/patches/3434/?format=json","web_url":"https://patchwork.libcamera.org/patch/3434/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200413133047.11913-2-laurent.pinchart@ideasonboard.com>","date":"2020-04-13T13:30:37","name":"[libcamera-devel,v2,01/11] ipa: vimc: Remove isolated VIMC IPA module","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4934834fe282f14a96fe8eba5e29c571e225f084","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3434/mbox/","series":[{"id":804,"url":"https://patchwork.libcamera.org/api/1.1/series/804/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=804","date":"2020-04-13T13:30:37","name":"Sign IPA modules instead of checking their advertised license","version":2,"mbox":"https://patchwork.libcamera.org/series/804/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3434/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3434/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C52256279B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Apr 2020 15:31:04 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC35BA42\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Apr 2020 15:31:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wbtM4jZU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1586784664;\n\tbh=Amlkw2VprPW1gZLRcrjNQGCwYpmPhBXlwPLt4HC4CDU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=wbtM4jZUge/mfhTxEvkLFRo5UcYuyyYWRm5L0rVBtWaG+rLvs48Zs/IQweJZlHyAQ\n\t5iRrBoz4VYSlJCByrefMAcgaX3kR1fs7VoWkI0qf+21PZwhyEiAKYwk8+fzSyhf0Nz\n\tDFjS0UAXFjn84Ioi5FsmSBu93z4Z4vTilQojUUCI=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 13 Apr 2020 16:30:37 +0300","Message-Id":"<20200413133047.11913-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200413133047.11913-1-laurent.pinchart@ideasonboard.com>","References":"<20200413133047.11913-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 01/11] ipa: vimc: Remove isolated VIMC\n\tIPA module","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 13 Apr 2020 13:31:05 -0000"},"content":"The isolated VIMC module isn't used in any test. Remove it to prepare\nfor the rework of IPA module isolation. The feature can be added back\nlater alongside corresponding tests if needed.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/ipa/vimc/meson.build | 23 ++++++++---------------\n 1 file changed, 8 insertions(+), 15 deletions(-)","diff":"diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\nindex 435c7d3160be..e827e75f9f91 100644\n--- a/src/ipa/vimc/meson.build\n+++ b/src/ipa/vimc/meson.build\n@@ -1,15 +1,8 @@\n-ipa_vimc_sources = [\n-    ['ipa_vimc',         'LGPL-2.1-or-later'],\n-    ['ipa_vimc_isolate', 'Proprietary'],\n-]\n-\n-foreach t : ipa_vimc_sources\n-    ipa = shared_module(t[0], 'vimc.cpp',\n-                        name_prefix : '',\n-                        include_directories : [ipa_includes, libipa_includes],\n-                        dependencies : libcamera_dep,\n-                        link_with : libipa,\n-                        install : true,\n-                        install_dir : ipa_install_dir,\n-                        cpp_args : '-DLICENSE=\"' + t[1] + '\"')\n-endforeach\n+ipa = shared_module('ipa_vimc', 'vimc.cpp',\n+                    name_prefix : '',\n+                    include_directories : [ipa_includes, libipa_includes],\n+                    dependencies : libcamera_dep,\n+                    link_with : libipa,\n+                    install : true,\n+                    install_dir : ipa_install_dir,\n+                    cpp_args : '-DLICENSE=\"LGPL-2.1-or-later\"')\n","prefixes":["libcamera-devel","v2","01/11"]}