{"id":3433,"url":"https://patchwork.libcamera.org/api/1.1/patches/3433/?format=json","web_url":"https://patchwork.libcamera.org/patch/3433/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200413104631.12276-5-email@uajain.com>","date":"2020-04-13T10:46:55","name":"[libcamera-devel,4/4] test: log: log_process: Close open fds on error paths","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"94e1012fd3953773e5bc45b4ea35ec36ed320f42","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3433/mbox/","series":[{"id":803,"url":"https://patchwork.libcamera.org/api/1.1/series/803/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=803","date":"2020-04-13T10:46:34","name":"Fix resource leaks pointed out by coverity scans","version":1,"mbox":"https://patchwork.libcamera.org/series/803/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3433/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3433/checks/","tags":{},"headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E08362826\n\tfor ;\n\tMon, 13 Apr 2020 12:46:56 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-xm5rk with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-xm5rk-18-5E94431F-1C\n\t2020-04-13 10:46:55.560459526 +0000 UTC m=+1513404.540192897","from mail.uajain.com (unknown)\n\tby ismtpd0002p1maa1.sendgrid.net (SG) with ESMTP\n\tid _MNMZXwcSO-p0tneNjxbog Mon, 13 Apr 2020 10:46:55.158 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"BJsVZW+n\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=lnej2EnrhGZdGHi+oYTyOl0lU5e/C29RGqqXEPQUKQ4=;\n\tb=BJsVZW+nAX00JqG/p0Soylu4bkZDCA1ImuQjge+hxsFMC7VF8ZIiCMMAc66qELoXKu1c\n\t/7X9FoKFjOLBxpBfdc7NghALpJxiDkMFj1IWfDSoStrqmsGgiWSjxj6v9HnLa+ENnqm/S4\n\to7WcXryy8v+8hTVHiarW1j767ILdhvge4=","From":"Umang Jain ","Date":"Mon, 13 Apr 2020 10:46:55 +0000 (UTC)","Message-Id":"<20200413104631.12276-5-email@uajain.com>","In-Reply-To":"<20200413104631.12276-1-email@uajain.com>","References":"<20200413104631.12276-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc9vLW9W8H4bP+KZ0PPVtun/auY9FtTkZgn/nQf0Y06iNRgTP5yjireSIn9mtcUeX2FiGxxLCfPxkM+JKJEEePO1hLNtYod9v4CjzeDnwqQHQOuZAaQxU7jS6Vv2SWz9OohMnAM4n6r1KPhUtje5DRCAJLjRgSDuje+0ToFImZ35QMxu2Nz6U4OxTLJfGR9hdLIvv1DH9hQ0cyBrCALM/BxQ==","To":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH 4/4] test: log: log_process: Close open\n\tfds on error paths","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 13 Apr 2020 10:46:57 -0000"},"content":"Pointed out by Coverity DefectId=279097\n\nSigned-off-by: Umang Jain \n---\n test/log/log_process.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\nindex 2df4aa4..88baa27 100644\n--- a/test/log/log_process.cpp\n+++ b/test/log/log_process.cpp\n@@ -106,6 +106,7 @@ protected:\n \t\tmemset(buf, 0, sizeof(buf));\n \t\tif (read(fd, buf, sizeof(buf)) < 0) {\n \t\t\tcerr << \"Failed to read tmp log file\" << endl;\n+\t\t\tclose(fd);\n \t\t\treturn TestFail;\n \t\t}\n \t\tclose(fd);\n","prefixes":["libcamera-devel","4/4"]}