{"id":3425,"url":"https://patchwork.libcamera.org/api/1.1/patches/3425/?format=json","web_url":"https://patchwork.libcamera.org/patch/3425/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200411001911.1143155-5-niklas.soderlund@ragnatech.se>","date":"2020-04-11T00:19:08","name":"[libcamera-devel,v3,4/7] libcamera: pipeline: rkisp1: Do not try to process cancelled frames","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7b0237ac7affd15c709d65906e3978fbda18a158","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3425/mbox/","series":[{"id":802,"url":"https://patchwork.libcamera.org/api/1.1/series/802/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=802","date":"2020-04-11T00:19:04","name":"libcamera: ipa_manager: Proxy open-source IPAs to a thread","version":3,"mbox":"https://patchwork.libcamera.org/series/802/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3425/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3425/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B9E76277E\n\tfor ;\n\tSat, 11 Apr 2020 02:19:23 +0200 (CEST)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 140ae63e-7b8a-11ea-aeed-005056917f90;\n\tSat, 11 Apr 2020 02:19:16 +0200 (CEST)"],"X-Halon-ID":"140ae63e-7b8a-11ea-aeed-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 11 Apr 2020 02:19:08 +0200","Message-Id":"<20200411001911.1143155-5-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.26.0","In-Reply-To":"<20200411001911.1143155-1-niklas.soderlund@ragnatech.se>","References":"<20200411001911.1143155-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 4/7] libcamera: pipeline: rkisp1: Do\n\tnot try to process cancelled frames","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 Apr 2020 00:19:23 -0000"},"content":"There is no need to try and process cancelled frames, try to finish as\nquickly as possible.\n\nSigned-off-by: Niklas Söderlund \n---\n* Changes since v2\n- If the buffer intended for the application is canceled complete it and\n the request as to not lockup applications.\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex de90615edf217cca..daf84b5ac129efc8 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1015,6 +1015,12 @@ void PipelineHandlerRkISP1::bufferReady(FrameBuffer *buffer)\n \tRkISP1CameraData *data = cameraData(activeCamera_);\n \tRequest *request = buffer->request();\n \n+\tif (buffer->metadata().status == FrameMetadata::FrameCancelled) {\n+\t\tcompleteBuffer(activeCamera_, request, buffer);\n+\t\tcompleteRequest(activeCamera_, request);\n+\t\treturn;\n+\t}\n+\n \tdata->timeline_.bufferReady(buffer);\n \n \tif (data->frame_ <= buffer->metadata().sequence)\n@@ -1026,6 +1032,9 @@ void PipelineHandlerRkISP1::bufferReady(FrameBuffer *buffer)\n \n void PipelineHandlerRkISP1::paramReady(FrameBuffer *buffer)\n {\n+\tif (buffer->metadata().status == FrameMetadata::FrameCancelled)\n+\t\treturn;\n+\n \tASSERT(activeCamera_);\n \tRkISP1CameraData *data = cameraData(activeCamera_);\n \n@@ -1037,6 +1046,9 @@ void PipelineHandlerRkISP1::paramReady(FrameBuffer *buffer)\n \n void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer)\n {\n+\tif (buffer->metadata().status == FrameMetadata::FrameCancelled)\n+\t\treturn;\n+\n \tASSERT(activeCamera_);\n \tRkISP1CameraData *data = cameraData(activeCamera_);\n \n","prefixes":["libcamera-devel","v3","4/7"]}