{"id":3338,"url":"https://patchwork.libcamera.org/api/1.1/patches/3338/?format=json","web_url":"https://patchwork.libcamera.org/patch/3338/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200326160819.4088361-4-niklas.soderlund@ragnatech.se>","date":"2020-03-26T16:08:15","name":"[libcamera-devel,RFCv2,3/7] libcamera: pipeline: rkisp1: Initialize IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b7a1769b5fadf46145e1d8faaec30d43a0a67de5","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3338/mbox/","series":[{"id":783,"url":"https://patchwork.libcamera.org/api/1.1/series/783/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=783","date":"2020-03-26T16:08:12","name":"libcamera: ipa_manager: Proxy open-source IPAs to a thread","version":1,"mbox":"https://patchwork.libcamera.org/series/783/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3338/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3338/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2A8F60414\n\tfor ;\n\tThu, 26 Mar 2020 17:10:33 +0100 (CET)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 4cfa37a5-6f7c-11ea-89d0-0050569116f7;\n\tThu, 26 Mar 2020 17:10:24 +0100 (CET)"],"X-Halon-ID":"4cfa37a5-6f7c-11ea-89d0-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 26 Mar 2020 17:08:15 +0100","Message-Id":"<20200326160819.4088361-4-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200326160819.4088361-1-niklas.soderlund@ragnatech.se>","References":"<20200326160819.4088361-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFCv2 3/7] libcamera: pipeline: rkisp1:\n\tInitialize IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 26 Mar 2020 16:10:34 -0000"},"content":"The IPA init() call is a no-op in the current IPA, but it's part of the\nIPA API and it should be called.\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 4ec74c5aa8286ffb..f64807984519779b 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -386,6 +386,8 @@ int RkISP1CameraData::loadIPA()\n \tipa_->queueFrameAction.connect(this,\n \t\t\t\t &RkISP1CameraData::queueFrameAction);\n \n+\tipa_->init();\n+\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","RFCv2","3/7"]}