{"id":3323,"url":"https://patchwork.libcamera.org/api/1.1/patches/3323/?format=json","web_url":"https://patchwork.libcamera.org/patch/3323/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200326013512.25425-1-laurent.pinchart@ideasonboard.com>","date":"2020-03-26T01:35:12","name":"[libcamera-devel] qcam: Print whole stream configuration when adjusted","commit_ref":"8c8fde05acd170f14ddbd395924819415a788eaf","pull_url":null,"state":"accepted","archived":false,"hash":"3f5cf3f1430f2dbd9d593e4c9a9e4b18d2361820","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3323/mbox/","series":[{"id":777,"url":"https://patchwork.libcamera.org/api/1.1/series/777/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=777","date":"2020-03-26T01:35:12","name":"[libcamera-devel] qcam: Print whole stream configuration when adjusted","version":1,"mbox":"https://patchwork.libcamera.org/series/777/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3323/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3323/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EC0860411\n\tfor ;\n\tThu, 26 Mar 2020 02:35:21 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E0AA2DC\n\tfor ;\n\tThu, 26 Mar 2020 02:35:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qO8suRyg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585186521;\n\tbh=3T9/s/5crVt4YZj/FE8gn1R1UHnE6deAiaFgLpKVD/o=;\n\th=From:To:Subject:Date:From;\n\tb=qO8suRygBwYgGzRPneATuOm+mTqFIw8qDvIPf7RnBcTL5iR9+Jg/GH04fzYyuu6xY\n\t0F+gmzmSWMPj/+pU1AMQ9plMF6xrx+vVTyrSZQuwk8vKY4yi9Vvdt3xcTkW9DEXNUq\n\trpj9xi0D7YAASnqdX91oVsjScc++beVxpSOWrqRY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 26 Mar 2020 03:35:12 +0200","Message-Id":"<20200326013512.25425-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] qcam: Print whole stream configuration\n\twhen adjusted","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 26 Mar 2020 01:35:21 -0000"},"content":"When the validate() function adjusts the stream configuration, we print\nthe adjusted size for debugging purpose. Switch to printing the whole\nconfiguration, as the pixel format may be useful too.\n\nSigned-off-by: Laurent Pinchart \n---\n src/qcam/main_window.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 565732698a5e..cf39ed7aceca 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -281,6 +281,7 @@ int MainWindow::startCapture()\n \tconfig_ = camera_->generateConfiguration({ StreamRole::Viewfinder });\n \n \tStreamConfiguration &cfg = config_->at(0);\n+\n \tif (options_.isSet(OptSize)) {\n \t\tconst std::vector &sizeOptions =\n \t\t\toptions_[OptSize].toArray();\n@@ -316,10 +317,9 @@ int MainWindow::startCapture()\n \t\treturn -EINVAL;\n \t}\n \n-\tif (validation == CameraConfiguration::Adjusted) {\n-\t\tqInfo() << \"Stream size adjusted to\"\n-\t\t\t<< cfg.size.toString().c_str();\n-\t}\n+\tif (validation == CameraConfiguration::Adjusted)\n+\t\tqInfo() << \"Stream configuration adjusted to \"\n+\t\t\t<< cfg.toString().c_str();\n \n \tret = camera_->configure(config_.get());\n \tif (ret < 0) {\n","prefixes":["libcamera-devel"]}