{"id":3250,"url":"https://patchwork.libcamera.org/api/1.1/patches/3250/?format=json","web_url":"https://patchwork.libcamera.org/patch/3250/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200323142205.28342-8-laurent.pinchart@ideasonboard.com>","date":"2020-03-23T14:21:51","name":"[libcamera-devel,07/21] qcam: main_window: Use icons from system icon theme","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c62257711a9af6e9bfe1581485c0ab34908cbcd1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3250/mbox/","series":[{"id":760,"url":"https://patchwork.libcamera.org/api/1.1/series/760/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=760","date":"2020-03-23T14:21:44","name":"qcam: Bypass format conversion when not required","version":1,"mbox":"https://patchwork.libcamera.org/series/760/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3250/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3250/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCFC962C50\n\tfor ;\n\tMon, 23 Mar 2020 15:22:20 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 59723A31\n\tfor ;\n\tMon, 23 Mar 2020 15:22:20 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584973340;\n\tbh=cVb52Stk9ppYJwFRDHb9aaavjPXSp25SbMpq6eRtJAE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=bX44HsgTSirrGPLg/BKJ4aag4pFdw6H9rlp+lqDzR5lbGrcaZXDpg28RG73bqJusL\n\tyaoXU9EIGzJdHk2xUoy9r2dQ2PDzhnnPrhzw7zJTj0i0DW66dj/SCkJQCczY7WLEAg\n\tIetjfbzcioyx2cvnkt7mbfr2EMBi31/CuEf4U3lE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Mar 2020 16:21:51 +0200","Message-Id":"<20200323142205.28342-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>","References":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 07/21] qcam: main_window: Use icons from\n\tsystem icon theme","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 14:22:24 -0000"},"content":"Use the system icon theme by default, falling back to custom icons if no\ntheme is available.\n\nSigned-off-by: Laurent Pinchart \n---\n src/qcam/main_window.cpp | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 86f92360a1a9..14baf7ec4c2e 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -97,7 +97,9 @@ int MainWindow::createToolbars()\n \t/* Disable right click context menu. */\n \ttoolbar_->setContextMenuPolicy(Qt::PreventContextMenu);\n \n-\taction = toolbar_->addAction(QIcon(\":x-circle.svg\"), \"Quit\");\n+\taction = toolbar_->addAction(QIcon::fromTheme(\"application-exit\",\n+\t\t\t\t\t\t QIcon(\":x-circle.svg\")),\n+\t\t\t\t \"Quit\");\n \tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n \n \t/* Camera selection. */\n@@ -112,12 +114,16 @@ int MainWindow::createToolbars()\n \n \ttoolbar_->addSeparator();\n \n-\taction = toolbar_->addAction(QIcon(\":play-circle.svg\"), \"Start Capture\");\n+\taction = toolbar_->addAction(QIcon::fromTheme(\"media-playback-start\",\n+\t\t\t\t\t\t QIcon(\":play-circle.svg\")),\n+\t\t\t\t \"Start Capture\");\n \taction->setCheckable(true);\n \tconnect(action, &QAction::toggled, this, &MainWindow::toggleCapture);\n \tstartStopAction_ = action;\n \n-\taction = toolbar_->addAction(QIcon(\":save.svg\"), \"saveAs\");\n+\taction = toolbar_->addAction(QIcon::fromTheme(\"document-save-as\",\n+\t\t\t\t\t\t QIcon(\":save.svg\")),\n+\t\t\t\t \"Save As...\");\n \tconnect(action, &QAction::triggered, this, &MainWindow::saveImageAs);\n \n \treturn 0;\n","prefixes":["libcamera-devel","07/21"]}