{"id":3233,"url":"https://patchwork.libcamera.org/api/1.1/patches/3233/?format=json","web_url":"https://patchwork.libcamera.org/patch/3233/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200321003640.2156-6-laurent.pinchart@ideasonboard.com>","date":"2020-03-21T00:36:38","name":"[libcamera-devel,v2,5/7] libcamera: v4l2_controls: Support U8 array controls","commit_ref":"55ead4647794072a4f4a866a65d18f8483c2998d","pull_url":null,"state":"accepted","archived":false,"hash":"20d5d9a2039bbeb1f0b1b6d737cf95dada903301","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3233/mbox/","series":[{"id":754,"url":"https://patchwork.libcamera.org/api/1.1/series/754/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=754","date":"2020-03-21T00:36:33","name":"Add support for V4L2 array controls","version":2,"mbox":"https://patchwork.libcamera.org/series/754/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3233/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3233/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A42060417\n\tfor ;\n\tSat, 21 Mar 2020 01:36:52 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1EE1613C2;\n\tSat, 21 Mar 2020 01:36:52 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584751012;\n\tbh=pBp1/PYh/igJaChzKg9zuLWL2Jc6myjZrMYMLO/Z5Pc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=EEDZFzgOU6dmv5pINKTGg65tWWZquVz+8B+OSoLkdas0F1M0UPFAwMw+9iPI1qgtI\n\tDbt2PnmENGdiLmY9a6LuPkzx8pEPPBVVtL071YVzv0nu7cWN1bucVV6faCBuoSlNiP\n\tlCAdOWuHNIZFA0Sf1o1vEFxOc6yv5GWzRX2hA4iU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 21 Mar 2020 02:36:38 +0200","Message-Id":"<20200321003640.2156-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200321003640.2156-1-laurent.pinchart@ideasonboard.com>","References":"<20200321003640.2156-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 5/7] libcamera: v4l2_controls: Support\n\tU8 array controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 21 Mar 2020 00:36:52 -0000"},"content":"From: Jacopo Mondi \n\nAdd support for array controls of type V4L2_CTRL_TYPE_U8.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/v4l2_controls.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\nindex 4861f9778df3..8e2415f2a6df 100644\n--- a/src/libcamera/v4l2_controls.cpp\n+++ b/src/libcamera/v4l2_controls.cpp\n@@ -60,6 +60,9 @@ std::string v4l2_ctrl_name(const struct v4l2_query_ext_ctrl &ctrl)\n ControlType v4l2_ctrl_type(const struct v4l2_query_ext_ctrl &ctrl)\n {\n \tswitch (ctrl.type) {\n+\tcase V4L2_CTRL_TYPE_U8:\n+\t\treturn ControlTypeByte;\n+\n \tcase V4L2_CTRL_TYPE_BOOLEAN:\n \t\treturn ControlTypeBool;\n \n@@ -119,6 +122,12 @@ V4L2ControlId::V4L2ControlId(const struct v4l2_query_ext_ctrl &ctrl)\n V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n {\n \tswitch (ctrl.type) {\n+\tcase V4L2_CTRL_TYPE_U8:\n+\t\tControlInfo::operator=(ControlInfo(static_cast(ctrl.minimum),\n+\t\t\t\t\t\t static_cast(ctrl.maximum),\n+\t\t\t\t\t\t static_cast(ctrl.default_value)));\n+\t\tbreak;\n+\n \tcase V4L2_CTRL_TYPE_BOOLEAN:\n \t\tControlInfo::operator=(ControlInfo(static_cast(ctrl.minimum),\n \t\t\t\t\t\t static_cast(ctrl.maximum),\n","prefixes":["libcamera-devel","v2","5/7"]}