{"id":3063,"url":"https://patchwork.libcamera.org/api/1.1/patches/3063/?format=json","web_url":"https://patchwork.libcamera.org/patch/3063/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200309123319.630-6-naush@raspberrypi.com>","date":"2020-03-09T12:33:18","name":"[libcamera-devel,v2,5/6] libcamera: controls: Update usage and description for existing controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"78bb5770aa06c1d78e1620ad29fcdf532548874b","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3063/mbox/","series":[{"id":715,"url":"https://patchwork.libcamera.org/api/1.1/series/715/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=715","date":"2020-03-09T12:33:13","name":"Patchset for libcamera controls","version":2,"mbox":"https://patchwork.libcamera.org/series/715/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3063/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3063/checks/","tags":{},"headers":{"Return-Path":"","Received":["from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1826C62923\n\tfor ;\n\tMon, 9 Mar 2020 13:35:37 +0100 (CET)","by mail-wm1-x343.google.com with SMTP id g62so4869863wme.1\n\tfor ;\n\tMon, 09 Mar 2020 05:35:37 -0700 (PDT)","from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net.\n\t[212.69.50.51]) by smtp.gmail.com with ESMTPSA id\n\tz135sm25693827wmc.20.2020.03.09.05.35.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 09 Mar 2020 05:35:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=32VL+kiTOWZatujbjBIETFjGTk9tbL9R8OZx5PH9JVg=;\n\tb=kcIFajR3TF8HXoaEm3DNqcOHPzE/R1wfjT1Zlmys/KOyAIBi/fM7BeePWf7H5NuVzO\n\ttiKFFNAlHv7LqlaB/kgz9COQgbXp7Z2h7Mlo+OP9UdMiyHywrdnj2/LRC8wT/UyP337T\n\tIciVav7o9ylU04P3AmgK3FYHgwob+opwg3Aeqrq5Vdv4MiZxbJmOdlxV1FRgH10m7UH3\n\t48DFo7a8lJqCG+Tw4bsHw3FrPbXKSFj8cELIY9FrqOCRe+WfGoIJrzUboZUFoMxt07iB\n\tqWcGHJrXHmxabDwsu92+B6DKh+z/ehvOgy3kf/Rlc4X6ZrugHtIr1wbBrpZ2l6HZIpTL\n\t1J8g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=32VL+kiTOWZatujbjBIETFjGTk9tbL9R8OZx5PH9JVg=;\n\tb=Yz3fZ/t0brKXffWtQO2osWAiz0QWQc+2bPt+RWTon6sKNVHIpvQVjEMkmZ5H+W6j/b\n\tDTGN/XTC0M5T47JjmIijmFw9sZWJrPG7WClYbJgrZMSqQ1/hpOq/zSzXHs6fGYKYLWvp\n\tY6JLhf8Xdy+fGGThaxsJrGUm+ArhuTXOSUQKbH3Hr1+IHAWDpKI6iiMBPVZHD9+nNfmA\n\tl47z3i3gqOSKMx2Q8HgdzO/d4HwHgOWs9f2v9Y+GOgEW2n5lJloV5qILSa44SucHSdDc\n\tygyhxDvRrvXqZaPVJcc8psQDKvxPdJIPcdzQwyFdIMvX87BT+orrnxykxNzMPbf98xS9\n\tGoDA==","X-Gm-Message-State":"ANhLgQ215KDjl4zJ04eu7G+tCvkVbB+c9WSbVWmMNPih4fN/RcFy4Yx0\n\t2jdJwH2BNMTU9+iIs9xBHU1oE4UQ7v6w2w==","X-Google-Smtp-Source":"ADFU+vtcnoafL16a3fOLFX1NcBlJpLc19UckgXXvsjI2tsYUKhzf77NlOfkl8hVOSkYOmkrOoR8EsA==","X-Received":"by 2002:a7b:c189:: with SMTP id y9mr7486233wmi.47.1583757336658; \n\tMon, 09 Mar 2020 05:35:36 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 9 Mar 2020 12:33:18 +0000","Message-Id":"<20200309123319.630-6-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20200309123319.630-1-naush@raspberrypi.com>","References":"<20200309123319.630-1-naush@raspberrypi.com>","Subject":"[libcamera-devel] [PATCH v2 5/6] libcamera: controls: Update usage\n\tand description for existing controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 09 Mar 2020 12:35:37 -0000"},"content":"Switch to using floats for constrast and saturation control to be more\nin-line with end-user expectations.\n\nExpand on the descrption for the brightness, contrast and saturation\ncontrols.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/control_ids.yaml | 17 ++++++++++++-----\n 1 file changed, 12 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 9a33094a..3d1b058f 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -192,13 +192,20 @@ controls:\n \n - Brightness:\n type: int32_t\n- description: Specify a fixed brightness parameter\n+ description: |\n+ Specify a fixed brightness parameter. Positive values (up to 65535)\n+ produce brighter images; negative values (up to -65536) produce darker\n+ images and 0 leaves pixels unchanged.\n \n - Contrast:\n- type: int32_t\n- description: Specify a fixed contrast parameter\n+ type: float\n+ description: |\n+ Specify a fixed contrast parameter. Normal contrast is given by the\n+ value 1.0; larger values produce images with more contrast.\n \n - Saturation:\n- type: int32_t\n- description: Specify a fixed saturation parameter\n+ type: float\n+ description: |\n+ Specify a fixed saturation parameter. Normal saturation is given by\n+ the value 1.0; larger values produce more saturated colours.\n ...\n","prefixes":["libcamera-devel","v2","5/6"]}