{"id":3057,"url":"https://patchwork.libcamera.org/api/1.1/patches/3057/?format=json","web_url":"https://patchwork.libcamera.org/patch/3057/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200308000433.2917-7-laurent.pinchart@ideasonboard.com>","date":"2020-03-08T00:04:33","name":"[libcamera-devel,v4,6/6] v4l2: v4l2_compat: Use correct libcamera_dep dependency","commit_ref":"20fb72a56eb3afe347ac058c13b8c84fbff1ed40","pull_url":null,"state":"accepted","archived":false,"hash":"61fbf6e0f60729f3126a2084017ed75a1d89bb8f","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3057/mbox/","series":[{"id":714,"url":"https://patchwork.libcamera.org/api/1.1/series/714/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=714","date":"2020-03-08T00:04:27","name":"Fix race condition and other build issues","version":4,"mbox":"https://patchwork.libcamera.org/series/714/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3057/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3057/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7A5E60424\n\tfor ;\n\tSun, 8 Mar 2020 01:04:44 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6075A5F\n\tfor ;\n\tSun, 8 Mar 2020 01:04:44 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583625884;\n\tbh=U9QS9lGGWSFk58zJoiLV/mtAfcTAQe2TccFXrPSQbGE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=VaGV/ILPdTdxHNDHpsDFw+SoLfG5WU56SIpWauIjr6mzsnevo0lW0nz3g9CvRaq15\n\tR8dNTdB1RubCPwjL/aOTRb5EtyuYwuiNSZfmnQeyMobagJe/+gct9IoC9yAN0vKSCJ\n\tfb+Jv/eoP8sVC1l1iJwS93nEbVGc0lJuzipNgnKk=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 8 Mar 2020 02:04:33 +0200","Message-Id":"<20200308000433.2917-7-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>","References":"<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 6/6] v4l2: v4l2_compat: Use correct\n\tlibcamera_dep dependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 08 Mar 2020 00:04:45 -0000"},"content":"The v4l2-compat shared library is declared as depending on\nlibcamera_deps. This is not correct, as libcamera_deps contains the\ndependencies of libcamera itself. The correct dependency for users of\nlibcamera is libcamera_dep.\n\nFixing this allows dropping libcamera_includes from the list of includes\nrequired by v4l2-compat, and libcamera from the link_with list, as they\nare already contained in libcamera_dep. We however need to add an\nexplicit dependency on libdl which was previously provided by\nlibcamera_deps.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\nChanges since v3:\n\n- Inline v4l2_compat_deps and v4l2_compat_includes\n- Use the libdl dependency object\n---\n src/v4l2/meson.build | 10 ++--------\n 1 file changed, 2 insertions(+), 8 deletions(-)","diff":"diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\nindex 14ee3594747d..efab968f7729 100644\n--- a/src/v4l2/meson.build\n+++ b/src/v4l2/meson.build\n@@ -5,11 +5,6 @@ v4l2_compat_sources = files([\n 'v4l2_compat_manager.cpp',\n ])\n \n-v4l2_compat_includes = [\n- libcamera_includes,\n- libcamera_internal_includes,\n-]\n-\n v4l2_compat_cpp_args = [\n # Meson enables large file support unconditionally, which redirect file\n # operations to 64-bit versions. This results in some symbols being\n@@ -25,7 +20,6 @@ v4l2_compat = shared_library('v4l2-compat',\n v4l2_compat_sources,\n name_prefix : '',\n install : true,\n- link_with : libcamera,\n- include_directories : v4l2_compat_includes,\n- dependencies : libcamera_deps,\n+ include_directories : libcamera_internal_includes,\n+ dependencies : [ libcamera_dep, libdl ],\n cpp_args : v4l2_compat_cpp_args)\n","prefixes":["libcamera-devel","v4","6/6"]}