{"id":3030,"url":"https://patchwork.libcamera.org/api/1.1/patches/3030/?format=json","web_url":"https://patchwork.libcamera.org/patch/3030/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306202637.525587-25-nicolas@ndufresne.ca>","date":"2020-03-06T20:26:34","name":"[libcamera-devel,v3,24/27] gst: libcamerasrc: Add a TODO comment","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0a9736baee90ecaca91986b6b1b806417968eb62","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/1.1/people/30/?format=json","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3030/mbox/","series":[{"id":705,"url":"https://patchwork.libcamera.org/api/1.1/series/705/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=705","date":"2020-03-06T20:26:10","name":"GStreamer Element for libcamera","version":3,"mbox":"https://patchwork.libcamera.org/series/705/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3030/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3030/checks/","tags":{},"headers":{"Return-Path":"<nicolas@ndufresne.ca>","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7336A628B3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  6 Mar 2020 21:27:12 +0100 (CET)","from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id DECE02970E7;\n\tFri,  6 Mar 2020 20:27:11 +0000 (GMT)"],"From":"Nicolas Dufresne <nicolas@ndufresne.ca>","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","Date":"Fri,  6 Mar 2020 15:26:34 -0500","Message-Id":"<20200306202637.525587-25-nicolas@ndufresne.ca>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306202637.525587-1-nicolas@ndufresne.ca>","References":"<20200306202637.525587-1-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 24/27] gst: libcamerasrc: Add a TODO\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 06 Mar 2020 20:27:12 -0000"},"content":"From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nThis is to guide upcoming contributors toward what is left to do to get\ntoward a production ready element.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 19 +++++++++++++++++++\n 1 file changed, 19 insertions(+)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex b04e9f1..8d0d0e1 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -7,6 +7,25 @@\n  */\n \n /**\n+ * \\todo The following is a list of items that needs implementation in the GStreamer plugin\n+ *  - Implement GstElement::send_event\n+ *    + Allowing application to send EOS\n+ *    + Allowing application to use FLUSH/FLUSH_STOP\n+ *    + Prevent the main thread from accessing streaming thread\n+ *  - Implement renegotiation (even if slow)\n+ *  - Implement GstElement::request-new-pad (multi stream)\n+ *    + Evaluate if a single streaming thread is fine\n+ *  - Add application driven request (snapshot)\n+ *  - Add framerate control\n+ *  - Add buffer importation support\n+ *\n+ *  Requires new libcamera API:\n+ *  - Add framerate negotiation support\n+ *  - Add colorimetry support\n+ *  - Add timestamp support\n+ *  - Use unique names to select the camera devices\n+ *  - Add GstVideoMeta support (strides and offsets)\n+ *\n  * \\todo libcamera UVC drivers picks the lowest possible resolution first, this\n  * should be fixed so that we get a decent resolution and framerate for the\n  * role by default.\n","prefixes":["libcamera-devel","v3","24/27"]}