{"id":3027,"url":"https://patchwork.libcamera.org/api/1.1/patches/3027/?format=json","web_url":"https://patchwork.libcamera.org/patch/3027/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306202637.525587-22-nicolas@ndufresne.ca>","date":"2020-03-06T20:26:31","name":"[libcamera-devel,v3,21/27] gst: pad: Add method to store retrieve pending buffers","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"050e4966bd51caad8334975ddc6f18b95cdc1a7a","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/1.1/people/30/?format=json","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3027/mbox/","series":[{"id":705,"url":"https://patchwork.libcamera.org/api/1.1/series/705/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=705","date":"2020-03-06T20:26:10","name":"GStreamer Element for libcamera","version":3,"mbox":"https://patchwork.libcamera.org/series/705/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3027/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3027/checks/","tags":{},"headers":{"Return-Path":"<nicolas@ndufresne.ca>","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E39B562922\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  6 Mar 2020 21:27:10 +0100 (CET)","from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 56F4E297189;\n\tFri,  6 Mar 2020 20:27:10 +0000 (GMT)"],"From":"Nicolas Dufresne <nicolas@ndufresne.ca>","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","Date":"Fri,  6 Mar 2020 15:26:31 -0500","Message-Id":"<20200306202637.525587-22-nicolas@ndufresne.ca>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306202637.525587-1-nicolas@ndufresne.ca>","References":"<20200306202637.525587-1-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 21/27] gst: pad: Add method to store\n\tretrieve pending buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 06 Mar 2020 20:27:12 -0000"},"content":"From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nThese will be useful for streaming. The requestComplete callback will\nstore the buffers on each pads so that the _run() can pick them up\nand push them through the pads from a streaming thread.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerapad.cpp | 27 +++++++++++++++++++++++++++\n src/gstreamer/gstlibcamerapad.h   |  4 ++++\n 2 files changed, 31 insertions(+)","diff":"diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex 8616e06..49dd35b 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -18,6 +18,7 @@ struct _GstLibcameraPad {\n \tGstPad parent;\n \tStreamRole role;\n \tGstLibcameraPool *pool;\n+\tGQueue pending_buffers;\n };\n \n enum {\n@@ -137,3 +138,29 @@ gst_libcamera_pad_get_stream(GstPad *pad)\n \n \treturn nullptr;\n }\n+\n+void\n+gst_libcamera_pad_queue_buffer(GstPad *pad, GstBuffer *buffer)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\tGLibLocker lock(GST_OBJECT(self));\n+\n+\tg_queue_push_head(&self->pending_buffers, buffer);\n+}\n+\n+GstFlowReturn\n+gst_libcamera_pad_push_pending(GstPad *pad)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\tGstBuffer *buffer;\n+\n+\t{\n+\t\tGLibLocker lock(GST_OBJECT(self));\n+\t\tbuffer = GST_BUFFER(g_queue_pop_tail(&self->pending_buffers));\n+\t}\n+\n+\tif (!buffer)\n+\t\treturn GST_FLOW_OK;\n+\n+\treturn gst_pad_push(pad, buffer);\n+}\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex f7dfc28..2e9ec20 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -26,4 +26,8 @@ void gst_libcamera_pad_set_pool(GstPad *pad, GstLibcameraPool *pool);\n \n libcamera::Stream *gst_libcamera_pad_get_stream(GstPad *pad);\n \n+void gst_libcamera_pad_queue_buffer(GstPad *pad, GstBuffer *buffer);\n+\n+GstFlowReturn gst_libcamera_pad_push_pending(GstPad *pad);\n+\n #endif /* __GST_LIBCAMERA_PAD_H__ */\n","prefixes":["libcamera-devel","v3","21/27"]}