{"id":3013,"url":"https://patchwork.libcamera.org/api/1.1/patches/3013/?format=json","web_url":"https://patchwork.libcamera.org/patch/3013/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306202637.525587-8-nicolas@ndufresne.ca>","date":"2020-03-06T20:26:17","name":"[libcamera-devel,v3,07/27] gst: libcamerasrc: Add camera-name property","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4b9938f0731e119dfcf02aed7446cd2246276955","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/1.1/people/30/?format=json","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3013/mbox/","series":[{"id":705,"url":"https://patchwork.libcamera.org/api/1.1/series/705/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=705","date":"2020-03-06T20:26:10","name":"GStreamer Element for libcamera","version":3,"mbox":"https://patchwork.libcamera.org/series/705/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3013/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3013/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84DF560424\n\tfor ;\n\tFri, 6 Mar 2020 21:27:03 +0100 (CET)","from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id C15A42970E7;\n\tFri, 6 Mar 2020 20:27:02 +0000 (GMT)"],"From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ,\n\tLaurent Pinchart ","Date":"Fri, 6 Mar 2020 15:26:17 -0500","Message-Id":"<20200306202637.525587-8-nicolas@ndufresne.ca>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306202637.525587-1-nicolas@ndufresne.ca>","References":"<20200306202637.525587-1-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 07/27] gst: libcamerasrc: Add\n\tcamera-name property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 20:27:03 -0000"},"content":"From: Nicolas Dufresne \n\nThis property will be used to select by name the camera to use.\n\nSigned-off-by: Nicolas Dufresne \nReviewed-by: Laurent Pinchart \n---\n src/gstreamer/gstlibcamerasrc.cpp | 68 ++++++++++++++++++++++++++++++-\n 1 file changed, 67 insertions(+), 1 deletion(-)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex cba936c..e0c1c4e 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -9,10 +9,17 @@\n #include \"gstlibcamerasrc.h\"\n \n #include \"gstlibcamerapad.h\"\n+#include \"gstlibcamera-utils.h\"\n \n struct _GstLibcameraSrc {\n \tGstElement parent;\n \tGstPad *srcpad;\n+\tgchar *camera_name;\n+};\n+\n+enum {\n+\tPROP_0,\n+\tPROP_CAMERA_NAME\n };\n \n G_DEFINE_TYPE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT);\n@@ -29,6 +36,52 @@ GstStaticPadTemplate request_src_template = {\n \t\"src_%s\", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS\n };\n \n+static void\n+gst_libcamera_src_set_property(GObject *object, guint prop_id,\n+\t\t\t const GValue *value, GParamSpec *pspec)\n+{\n+\tGLibLocker lock(GST_OBJECT(object));\n+\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(object);\n+\n+\tswitch (prop_id) {\n+\tcase PROP_CAMERA_NAME:\n+\t\tg_free(self->camera_name);\n+\t\tself->camera_name = g_value_dup_string(value);\n+\t\tbreak;\n+\tdefault:\n+\t\tG_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n+\t\tbreak;\n+\t}\n+}\n+\n+static void\n+gst_libcamera_src_get_property(GObject *object, guint prop_id, GValue *value,\n+\t\t\t GParamSpec *pspec)\n+{\n+\tGLibLocker lock(GST_OBJECT(object));\n+\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(object);\n+\n+\tswitch (prop_id) {\n+\tcase PROP_CAMERA_NAME:\n+\t\tg_value_set_string(value, self->camera_name);\n+\t\tbreak;\n+\tdefault:\n+\t\tG_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n+\t\tbreak;\n+\t}\n+}\n+\n+static void\n+gst_libcamera_src_finalize(GObject *object)\n+{\n+\tGObjectClass *klass = G_OBJECT_CLASS(gst_libcamera_src_parent_class);\n+\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(object);\n+\n+\tg_free(self->camera_name);\n+\n+\treturn klass->finalize(object);\n+}\n+\n static void\n gst_libcamera_src_init(GstLibcameraSrc *self)\n {\n@@ -41,7 +94,12 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n static void\n gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n {\n-\tGstElementClass *element_class = (GstElementClass *)klass;\n+\tGstElementClass *element_class = GST_ELEMENT_CLASS(klass);\n+\tGObjectClass *object_class = G_OBJECT_CLASS(klass);\n+\n+\tobject_class->set_property = gst_libcamera_src_set_property;\n+\tobject_class->get_property = gst_libcamera_src_get_property;\n+\tobject_class->finalize = gst_libcamera_src_finalize;\n \n \tgst_element_class_set_metadata(element_class,\n \t\t\t\t \"libcamera Source\", \"Source/Video\",\n@@ -53,4 +111,12 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n \tgst_element_class_add_static_pad_template_with_gtype(element_class,\n \t\t\t\t\t\t\t &request_src_template,\n \t\t\t\t\t\t\t GST_TYPE_LIBCAMERA_PAD);\n+\n+\tGParamSpec *spec = g_param_spec_string(\"camera-name\", \"Camera Name\",\n+\t\t\t\t\t \"Select by name which camera to use.\", nullptr,\n+\t\t\t\t\t (GParamFlags)(GST_PARAM_MUTABLE_READY\n+\t\t\t\t\t\t\t | G_PARAM_CONSTRUCT\n+\t\t\t\t\t\t\t | G_PARAM_READWRITE\n+\t\t\t\t\t\t\t | G_PARAM_STATIC_STRINGS));\n+\tg_object_class_install_property(object_class, PROP_CAMERA_NAME, spec);\n }\n","prefixes":["libcamera-devel","v3","07/27"]}