{"id":2986,"url":"https://patchwork.libcamera.org/api/1.1/patches/2986/?format=json","web_url":"https://patchwork.libcamera.org/patch/2986/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306160002.30549-15-laurent.pinchart@ideasonboard.com>","date":"2020-03-06T15:59:44","name":"[libcamera-devel,v2,14/32] libcamera: controls: Move Control constructor to controls.h","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e46a43573de388a219be00448817bd29d57621c5","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2986/mbox/","series":[{"id":703,"url":"https://patchwork.libcamera.org/api/1.1/series/703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=703","date":"2020-03-06T15:59:30","name":"libcamera: Add support for array controls","version":2,"mbox":"https://patchwork.libcamera.org/series/703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2986/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2986/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 53DC460424\n\tfor ;\n\tFri, 6 Mar 2020 17:00:21 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3A7E1265\n\tfor ;\n\tFri, 6 Mar 2020 17:00:20 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510421;\n\tbh=ZlztJ5jHqC8Ob6WTYkXDBjBUwm3pr78ZBGAobchiMNs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=dDXtDkxFVoox3rLyU6cwyjI3ptXtJw7Id0P/VhSVJgoKIV8BzwkzqQ0E3zI+2gxn1\n\tfzsqfysv+F1cGMBHrVHUt9E1Mj/fZgzX7uXzc8ztSFA5XKN91F1qnE97YmHHeHrD5U\n\tgoUIbG3+qioiDwvrvb7WYOX7ARoVQIRj85R0uPec=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Mar 2020 17:59:44 +0200","Message-Id":"<20200306160002.30549-15-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","References":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 14/32] libcamera: controls: Move\n\tControl constructor to controls.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 16:00:21 -0000"},"content":"To avoid defining all specializations of the Control constructor\nmanually, move the definition of those functions to controls.h and turn\nthem into a single template function.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n include/libcamera/controls.h | 5 ++++-\n src/libcamera/controls.cpp | 26 --------------------------\n 2 files changed, 4 insertions(+), 27 deletions(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex dfe69916cd64..6f0ebf4f3ca5 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -146,7 +146,10 @@ class Control : public ControlId\n public:\n \tusing type = T;\n \n-\tControl(unsigned int id, const char *name);\n+\tControl(unsigned int id, const char *name)\n+\t\t: ControlId(id, name, details::control_type>::value)\n+\t{\n+\t}\n \n private:\n \tControl(const Control &) = delete;\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 5cc8ce2199d0..76230a052de1 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -249,32 +249,6 @@ bool ControlValue::operator==(const ControlValue &other) const\n * \\brief The Control template type T\n */\n \n-#ifndef __DOXYGEN__\n-template<>\n-Control::Control(unsigned int id, const char *name)\n-\t: ControlId(id, name, ControlTypeNone)\n-{\n-}\n-\n-template<>\n-Control::Control(unsigned int id, const char *name)\n-\t: ControlId(id, name, ControlTypeBool)\n-{\n-}\n-\n-template<>\n-Control::Control(unsigned int id, const char *name)\n-\t: ControlId(id, name, ControlTypeInteger32)\n-{\n-}\n-\n-template<>\n-Control::Control(unsigned int id, const char *name)\n-\t: ControlId(id, name, ControlTypeInteger64)\n-{\n-}\n-#endif /* __DOXYGEN__ */\n-\n /**\n * \\class ControlRange\n * \\brief Describe the limits of valid values for a Control\n","prefixes":["libcamera-devel","v2","14/32"]}