{"id":2985,"url":"https://patchwork.libcamera.org/api/1.1/patches/2985/?format=json","web_url":"https://patchwork.libcamera.org/patch/2985/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306160002.30549-13-laurent.pinchart@ideasonboard.com>","date":"2020-03-06T15:59:42","name":"[libcamera-devel,v2,12/32] libcamera: controls: Move ControlValue get() and set() to controls.h","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9a84ee9ff7782f322fab7c85ee8b30c293d378fd","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2985/mbox/","series":[{"id":703,"url":"https://patchwork.libcamera.org/api/1.1/series/703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=703","date":"2020-03-06T15:59:30","name":"libcamera: Add support for array controls","version":2,"mbox":"https://patchwork.libcamera.org/series/703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2985/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2985/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84302628D6\n\tfor ;\n\tFri, 6 Mar 2020 17:00:20 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68BEC24B\n\tfor ;\n\tFri, 6 Mar 2020 17:00:19 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510419;\n\tbh=kKXSORO7rK9owRXcTQZzLu5E7hy1IhLtxIObOgL0EBE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=DSiwMBBbJ2r50X7XprlYYOGJGIZ1QKzhHRVdHrvUKfsfIZ7BfUMozqyTqTSd8ch71\n\tQf64CMVXI50GylAqbTZlSnSGkfH+LULdDGk1BwoQImV7vdD74qJxwA9HHbzHC9BIfN\n\tJFHuGv4H/7u23vOZwdt6nmCjjmFCEVLjv+Nf+QI4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Mar 2020 17:59:42 +0200","Message-Id":"<20200306160002.30549-13-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","References":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 12/32] libcamera: controls: Move\n\tControlValue get() and set() to controls.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 16:00:21 -0000"},"content":"To avoid defining all specializations of ControlValue::get() and\nControlValue::set() manually, move the definition of those functions to\ncontrols.h and turn them into single template functions.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n include/libcamera/controls.h | 15 ++++++++++--\n src/libcamera/controls.cpp | 47 ------------------------------------\n 2 files changed, 13 insertions(+), 49 deletions(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 429f01b0fd24..39e240438861 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -8,6 +8,7 @@\n #ifndef __LIBCAMERA_CONTROLS_H__\n #define __LIBCAMERA_CONTROLS_H__\n \n+#include \n #include \n #include \n \n@@ -70,9 +71,19 @@ public:\n \t}\n \n \ttemplate\n-\tT get() const;\n+\tT get() const\n+\t{\n+\t\tassert(type_ == details::control_type>::value);\n+\n+\t\treturn *reinterpret_cast(&bool_);\n+\t}\n+\n \ttemplate\n-\tvoid set(const T &value);\n+\tvoid set(const T &value)\n+\t{\n+\t\ttype_ = details::control_type>::value;\n+\t\t*reinterpret_cast(&bool_) = value;\n+\t}\n \n private:\n \tControlType type_;\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 6a0d66fbea8d..f3d79785e6a8 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -175,53 +175,6 @@ bool ControlValue::operator==(const ControlValue &other) const\n * \\param[in] value The control value\n */\n \n-#ifndef __DOXYGEN__\n-template<>\n-bool ControlValue::get() const\n-{\n-\tASSERT(type_ == ControlTypeBool);\n-\n-\treturn bool_;\n-}\n-\n-template<>\n-int32_t ControlValue::get() const\n-{\n-\tASSERT(type_ == ControlTypeInteger32);\n-\n-\treturn integer32_;\n-}\n-\n-template<>\n-int64_t ControlValue::get() const\n-{\n-\tASSERT(type_ == ControlTypeInteger64);\n-\n-\treturn integer64_;\n-}\n-\n-template<>\n-void ControlValue::set(const bool &value)\n-{\n-\ttype_ = ControlTypeBool;\n-\tbool_ = value;\n-}\n-\n-template<>\n-void ControlValue::set(const int32_t &value)\n-{\n-\ttype_ = ControlTypeInteger32;\n-\tinteger32_ = value;\n-}\n-\n-template<>\n-void ControlValue::set(const int64_t &value)\n-{\n-\ttype_ = ControlTypeInteger64;\n-\tinteger64_ = value;\n-}\n-#endif /* __DOXYGEN__ */\n-\n /**\n * \\class ControlId\n * \\brief Control static metadata\n","prefixes":["libcamera-devel","v2","12/32"]}