{"id":2975,"url":"https://patchwork.libcamera.org/api/1.1/patches/2975/?format=json","web_url":"https://patchwork.libcamera.org/patch/2975/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306160002.30549-4-laurent.pinchart@ideasonboard.com>","date":"2020-03-06T15:59:33","name":"[libcamera-devel,v2,03/32] libcamera: gen-controls: Fix documentation issue with <<","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7174766e0557665e9d6dde06a61e72a7d25070d5","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2975/mbox/","series":[{"id":703,"url":"https://patchwork.libcamera.org/api/1.1/series/703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=703","date":"2020-03-06T15:59:30","name":"libcamera: Add support for array controls","version":2,"mbox":"https://patchwork.libcamera.org/series/703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2975/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2975/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB45F6285C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  6 Mar 2020 17:00:12 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B444A48;\n\tFri,  6 Mar 2020 17:00:12 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510412;\n\tbh=ZBHYvBkcVV4MISNlXC1xizfdw9CupPYqZuw++xBl9dM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=isz8UD2HI6vZocTmiOc59CpLKD14S3dOcLbNvNLgCdhusR4gpTpjaTc5SP/FqKv2j\n\t2fkH10YrI1frTP5DNJ4Ld7Vq4q4bX8gahripqLCygnyi5JVTIfaS91kviSM4n037ZG\n\t7G1XVAlCy9k5CpRnN15xDDZal4oTNG9sK788Vt8U=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri,  6 Mar 2020 17:59:33 +0200","Message-Id":"<20200306160002.30549-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","References":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 03/32] libcamera: gen-controls: Fix\n\tdocumentation issue with <<","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 06 Mar 2020 16:00:13 -0000"},"content":"From: Jacopo Mondi <jacopo@jmondi.org>\n\nDoxygen fails to parse entries with multiple << signs as, in example,\n\\var extern const Control<Span<int32_t>>\n\nRemove the type from the control documentation as unique control and\nproperty names should not need any additional information specified for\nDoxygen to correctly identify them.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\nChanges since v1:\n\n- Commit message updates\n---\n src/libcamera/gen-controls.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/gen-controls.py b/src/libcamera/gen-controls.py\nindex 773e9b5d170c..6f020a327827 100755\n--- a/src/libcamera/gen-controls.py\n+++ b/src/libcamera/gen-controls.py\n@@ -29,7 +29,7 @@ def generate_cpp(controls):\n     enum_doc_value_template = string.Template(''' * \\\\var ${name}Values::${value}\n ${description}''')\n     doc_template = string.Template('''/**\n- * \\\\var extern const Control<${type}> ${name}\n+ * \\\\var ${name}\n ${description}\n  */''')\n     def_template = string.Template('extern const Control<${type}> ${name}(${id_name}, \"${name}\");')\n","prefixes":["libcamera-devel","v2","03/32"]}