{"id":2969,"url":"https://patchwork.libcamera.org/api/1.1/patches/2969/?format=json","web_url":"https://patchwork.libcamera.org/patch/2969/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200305203808.536050-6-niklas.soderlund@ragnatech.se>","date":"2020-03-05T20:38:06","name":"[libcamera-devel,v4,5/7] libcamera: V4L2BufferCache: Check for hot hit first","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"04d03850cb3eb4262dcaacfdf90c940eb144d47c","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2969/mbox/","series":[{"id":702,"url":"https://patchwork.libcamera.org/api/1.1/series/702/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=702","date":"2020-03-05T20:38:01","name":"libcamera: V4L2BufferCache: Improve cache eviction strategy","version":4,"mbox":"https://patchwork.libcamera.org/series/702/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2969/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2969/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A8FF60427\n\tfor ;\n\tThu, 5 Mar 2020 21:38:23 +0100 (CET)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 413d1dc8-5f21-11ea-9f85-005056917a89;\n\tThu, 05 Mar 2020 21:38:22 +0100 (CET)"],"X-Halon-ID":"413d1dc8-5f21-11ea-9f85-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 5 Mar 2020 21:38:06 +0100","Message-Id":"<20200305203808.536050-6-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200305203808.536050-1-niklas.soderlund@ragnatech.se>","References":"<20200305203808.536050-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 5/7] libcamera: V4L2BufferCache: Check\n\tfor hot hit first","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 05 Mar 2020 20:38:23 -0000"},"content":"Check for a hot cache hit before updating which buffer is best to evict\nin case no hot hit is found. This doesn't change the behaviour, but\nfollows a more logical flow.\n\nSuggested-by: Jacopo Mondi \nSigned-off-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/v4l2_videodevice.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 268de60bc7965f58..c495de85f26efe14 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -212,15 +212,15 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n \t\tif (!entry.free)\n \t\t\tcontinue;\n \n-\t\tif (use < 0)\n-\t\t\tuse = index;\n-\n \t\t/* Try to find a cache hit by comparing the planes. */\n \t\tif (entry == buffer) {\n \t\t\thit = true;\n \t\t\tuse = index;\n \t\t\tbreak;\n \t\t}\n+\n+\t\tif (use < 0)\n+\t\t\tuse = index;\n \t}\n \n \tif (!hit)\n","prefixes":["libcamera-devel","v4","5/7"]}