{"id":292,"url":"https://patchwork.libcamera.org/api/1.1/patches/292/?format=json","web_url":"https://patchwork.libcamera.org/patch/292/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190121114126.19577-1-kieran.bingham@ideasonboard.com>","date":"2019-01-21T11:41:26","name":"[libcamera-devel] libcamera: camera_manager: Return EBUSY if enumerator exists","commit_ref":"29c3b54f0c8ec7e3aeed8971d24f939bc4bfab04","pull_url":null,"state":"accepted","archived":false,"hash":"c938328faad3b00840235c6ce58d44f11ef5bf0c","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/292/mbox/","series":[{"id":100,"url":"https://patchwork.libcamera.org/api/1.1/series/100/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=100","date":"2019-01-21T11:41:26","name":"[libcamera-devel] libcamera: camera_manager: Return EBUSY if enumerator exists","version":1,"mbox":"https://patchwork.libcamera.org/series/100/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/292/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/292/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7459860C7F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jan 2019 12:41:30 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E9E4641;\n\tMon, 21 Jan 2019 12:41:29 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548070890;\n\tbh=lsOBty2q/V1Y0/EHq36SGgmBv2juJBnIgUXXFJdPucA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=jDctejC7lyjJqVPfp19trWMg/dADjVPleHAI+BPmpkUC/aGMOqL754N1AmqO3WpV+\n\t870KjO1ZfRwNZ8gwgNSMH0nzsVK09t9+5KYgslPV5wyEt2NXmAPUufIbY3ncXNEXu+\n\t8rnzI+0Q5zst/2rW1XEWCbFfLW30B8LGD+DQHqjQ=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Date":"Mon, 21 Jan 2019 11:41:26 +0000","Message-Id":"<20190121114126.19577-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.17.1","Subject":"[libcamera-devel] [PATCH] libcamera: camera_manager: Return EBUSY\n\tif enumerator exists","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 21 Jan 2019 11:41:30 -0000"},"content":"In the case that someone calls CameraManager::start() and it has already\nstarted/enumerated, instead of returning -ENODEV, return -EBUSY.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/camera_manager.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex d76eaa7ace86..21cb36dcb9b5 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -76,7 +76,7 @@ CameraManager::~CameraManager()\n int CameraManager::start()\n {\n \tif (enumerator_)\n-\t\treturn -ENODEV;\n+\t\treturn -EBUSY;\n \n \tenumerator_ = DeviceEnumerator::create();\n \tif (enumerator_->enumerate())\n","prefixes":["libcamera-devel"]}