{"id":2894,"url":"https://patchwork.libcamera.org/api/1.1/patches/2894/?format=json","web_url":"https://patchwork.libcamera.org/patch/2894/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200227200407.490616-13-nicolas.dufresne@collabora.com>","date":"2020-02-27T20:03:52","name":"[libcamera-devel,v2,12/27] gst: libcamerasrc: Store the srcpad in a vector","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ef57cb450d96744d7de7b856b5c7e3dd5f81454c","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/1.1/people/31/?format=json","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2894/mbox/","series":[{"id":693,"url":"https://patchwork.libcamera.org/api/1.1/series/693/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=693","date":"2020-02-27T20:03:40","name":"GStreamer Element for libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/693/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2894/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2894/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 922E8626F6\n\tfor ;\n\tThu, 27 Feb 2020 21:04:23 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id 0A34D29654A"],"From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 27 Feb 2020 15:03:52 -0500","Message-Id":"<20200227200407.490616-13-nicolas.dufresne@collabora.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200227200407.490616-1-nicolas.dufresne@collabora.com>","References":"<20200227200407.490616-1-nicolas.dufresne@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 12/27] gst: libcamerasrc: Store the\n\tsrcpad in a vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 27 Feb 2020 20:04:24 -0000"},"content":"This will allow implementing generic algorithm even if we cannot\nrequest pads yet.\n\nSigned-off-by: Nicolas Dufresne \nReviewed-by: Laurent Pinchart \n---\n src/gstreamer/gstlibcamerasrc.cpp | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 53ece26..5a86a6d 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -12,6 +12,7 @@\n \n #include \n #include \n+#include \n \n using namespace libcamera;\n \n@@ -22,6 +23,7 @@ GST_DEBUG_CATEGORY_STATIC(source_debug);\n struct GstLibcameraSrcState {\n \tstd::unique_ptr cm;\n \tstd::shared_ptr cam;\n+\tstd::vector srcpads;\n };\n \n struct _GstLibcameraSrc {\n@@ -29,7 +31,6 @@ struct _GstLibcameraSrc {\n \n \tGRecMutex stream_lock;\n \tGstTask *task;\n-\tGstPad *srcpad;\n \n \tgchar *camera_name;\n \n@@ -262,8 +263,8 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n \tgst_task_set_leave_callback(self->task, gst_libcamera_src_task_leave, self, nullptr);\n \tgst_task_set_lock(self->task, &self->stream_lock);\n \n-\tself->srcpad = gst_pad_new_from_template(templ, \"src\");\n-\tgst_element_add_pad(GST_ELEMENT(self), self->srcpad);\n+\tstate->srcpads.push_back(gst_pad_new_from_template(templ, \"src\"));\n+\tgst_element_add_pad(GST_ELEMENT(self), state->srcpads[0]);\n \tself->state = state;\n }\n \n","prefixes":["libcamera-devel","v2","12/27"]}