{"id":2865,"url":"https://patchwork.libcamera.org/api/1.1/patches/2865/?format=json","web_url":"https://patchwork.libcamera.org/patch/2865/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200220165704.23600-7-kieran.bingham@ideasonboard.com>","date":"2020-02-20T16:57:04","name":"[libcamera-devel,v3,6/6] tests: Remove IPA_MODULE_PATH environment variable","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a22016ab6923cf9bdefdec6371aa0fa21f16c04e","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2865/mbox/","series":[{"id":688,"url":"https://patchwork.libcamera.org/api/1.1/series/688/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=688","date":"2020-02-20T16:56:58","name":"Support loading IPAs from the build tree","version":3,"mbox":"https://patchwork.libcamera.org/series/688/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2865/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2865/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4EAB625F2\n\tfor ;\n\tThu, 20 Feb 2020 17:57:09 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C638563;\n\tThu, 20 Feb 2020 17:57:09 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582217829;\n\tbh=o825z2mBmqGgfOlpAMuJrhE+WpWInSwjhg8rDuYV63k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=t/z+9BaSBA1eBH8e5c8vk4EiuSlQDDJ2RgxIDGh3rNzzPICV6yb4SJR7P3XJl99YR\n\tTyT/JXlGluUL/yEM2az6luVvwTqLn0lnrQfPi3ixnn1sS9XvsbGJqKkhTUQJhhfB6R\n\tehVhqbSWAWGaAYHo2C7QP3SY/LBjwOrAiFI+CJ8M=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Thu, 20 Feb 2020 16:57:04 +0000","Message-Id":"<20200220165704.23600-7-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20200220165704.23600-1-kieran.bingham@ideasonboard.com>","References":"<20200220165704.23600-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 6/6] tests: Remove IPA_MODULE_PATH\n\tenvironment variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 20 Feb 2020 16:57:11 -0000"},"content":"The tests declare a hard-coded LIBCAMERA_IPA_MODULE_PATH to allow tests\nto run from the test-suite.\n\nThis requires tests to be run only from the root of the build directory,\notherwise (for example, by running in their local directory) they will\nnot be able to correctly locate the IPA modules.\n\nNow that the build path for the IPA manager is determined at runtime we\ncan remove the redundant setting of the LIBCAMERA_IPA_MODULE_PATH for\ntests.\n\nSigned-off-by: Kieran Bingham \n---\n test/libtest/test.cpp | 4 ----\n 1 file changed, 4 deletions(-)","diff":"diff --git a/test/libtest/test.cpp b/test/libtest/test.cpp\nindex 333d2160e276..6cd3fbe6df06 100644\n--- a/test/libtest/test.cpp\n+++ b/test/libtest/test.cpp\n@@ -21,10 +21,6 @@ int Test::execute()\n {\n \tint ret;\n \n-\tret = setenv(\"LIBCAMERA_IPA_MODULE_PATH\", \"src/ipa\", 1);\n-\tif (ret)\n-\t\treturn errno;\n-\n \tret = setenv(\"LIBCAMERA_IPA_PROXY_PATH\", \"src/libcamera/proxy/worker\", 1);\n \tif (ret)\n \t\treturn errno;\n","prefixes":["libcamera-devel","v3","6/6"]}