{"id":279,"url":"https://patchwork.libcamera.org/api/1.1/patches/279/?format=json","web_url":"https://patchwork.libcamera.org/patch/279/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190120140435.23252-1-niklas.soderlund@ragnatech.se>","date":"2019-01-20T14:04:35","name":"[libcamera-devel,v2] libcamera: device_enumerator: extend documentation of DeviceMatch","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"93556a88a2cfc9b53baf552903d31cdb212299c3","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/279/mbox/","series":[{"id":95,"url":"https://patchwork.libcamera.org/api/1.1/series/95/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=95","date":"2019-01-20T14:04:35","name":"[libcamera-devel,v2] libcamera: device_enumerator: extend documentation of DeviceMatch","version":2,"mbox":"https://patchwork.libcamera.org/series/95/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/279/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/279/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1694860C81\n\tfor ;\n\tSun, 20 Jan 2019 15:06:41 +0100 (CET)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 98844484-1cbc-11e9-874f-005056917f90;\n\tSun, 20 Jan 2019 15:06:37 +0100 (CET)"],"X-Halon-ID":"98844484-1cbc-11e9-874f-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 20 Jan 2019 15:04:35 +0100","Message-Id":"<20190120140435.23252-1-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] libcamera: device_enumerator: extend\n\tdocumentation of DeviceMatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 20 Jan 2019 14:06:41 -0000"},"content":"Extend the document of the intended usage of DeviceMatch need for\ninformation to correctly function to find a uniquely identifiable media\ndevice.\n\nSigned-off-by: Niklas Söderlund \n---\n* Changes since v1\n- Rephrased most of it after review comments from Laurent, Thanks!\n\n src/libcamera/device_enumerator.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex 55c510e3b79a415b..d41e1e580b3451ab 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -52,6 +52,18 @@ namespace libcamera {\n *\n * The description is meant to be filled by pipeline managers and passed to a\n * device enumerator to find matching media devices.\n+ *\n+ * A DeviceMatch is created with a specific Linux device driver in mind,\n+ * therefore the name of the driver is a required property. One or more Entity\n+ * names can be added as as match criteria.\n+ *\n+ * Pipeline handlers are recommended to add entities to DeviceMatch as\n+ * appropriare to ensure that the media device they need can be uniquely\n+ * identified. This is useful when the corresponding kernel driver can produce\n+ * different graphs, for instance as a result of different driver versions or\n+ * hardware configurations, and not all those graphs are suitable for a pipeline\n+ * handler.\n+ *\n */\n \n /**\n","prefixes":["libcamera-devel","v2"]}