{"id":2747,"url":"https://patchwork.libcamera.org/api/1.1/patches/2747/?format=json","web_url":"https://patchwork.libcamera.org/patch/2747/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200129033210.278800-14-nicolas@ndufresne.ca>","date":"2020-01-29T03:32:00","name":"[libcamera-devel,v1,13/23] gst: libcamerasrc: Send stream start event","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0473d2b442c7758c259e54f7ba5a0c15b8a5d238","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/1.1/people/30/?format=json","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2747/mbox/","series":[{"id":648,"url":"https://patchwork.libcamera.org/api/1.1/series/648/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=648","date":"2020-01-29T03:31:47","name":"GStreamer Element for libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/648/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2747/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2747/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AB7D608B9\n\tfor ;\n\tWed, 29 Jan 2020 04:35:33 +0100 (CET)","from nicolas-tpx395.localdomain (unknown\n\t[IPv6:2002:c0de:c115:0:66fc:8b:2a38:8313])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 52E7F292988;\n\tWed, 29 Jan 2020 03:35:32 +0000 (GMT)"],"From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ","Date":"Tue, 28 Jan 2020 22:32:00 -0500","Message-Id":"<20200129033210.278800-14-nicolas@ndufresne.ca>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200129033210.278800-1-nicolas@ndufresne.ca>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 13/23] gst: libcamerasrc: Send stream\n\tstart event","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 Jan 2020 03:35:33 -0000"},"content":"From: Nicolas Dufresne \n\nPrior to sending caps, we need to send a stream-start event. This requires\ngenerating a stream and a group id. The stream id is random for live sources and\nthe group id is shared across all pads.\n\nSigned-off-by: Nicolas Dufresne \n---\n src/gstreamer/gstlibcamerasrc.cpp | 13 +++++++++++++\n 1 file changed, 13 insertions(+)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex be32a11..b1a21dc 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -18,6 +18,8 @@ using namespace libcamera;\n GST_DEBUG_CATEGORY_STATIC(source_debug);\n #define GST_CAT_DEFAULT source_debug\n \n+#define STREAM_LOCKER(obj) g_autoptr(GRecMutexLocker) stream_locker = g_rec_mutex_locker_new(&GST_LIBCAMERA_SRC(obj)->stream_lock)\n+\n /* Used for C++ object with destructors */\n struct GstLibcameraSrcState {\n \tstd::shared_ptr cm;\n@@ -127,9 +129,20 @@ gst_libcamera_src_task_run(gpointer user_data)\n static void\n gst_libcamera_src_task_enter(GstTask *task, GThread *thread, gpointer user_data)\n {\n+\tSTREAM_LOCKER(user_data);\n \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n+\tGstLibcameraSrcState *state = self->state;\n \n \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n+\n+\tguint group_id = gst_util_group_id_next();\n+\tfor (GstPad *srcpad : state->srcpads) {\n+\t\t/* Create stream-id and push stream-start */\n+\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), nullptr);\n+\t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n+\t\tgst_event_set_group_id(event, group_id);\n+\t\tgst_pad_push_event(srcpad, event);\n+\t}\n }\n \n static void\n","prefixes":["libcamera-devel","v1","13/23"]}