{"id":2738,"url":"https://patchwork.libcamera.org/api/1.1/patches/2738/?format=json","web_url":"https://patchwork.libcamera.org/patch/2738/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200129033210.278800-5-nicolas@ndufresne.ca>","date":"2020-01-29T03:31:51","name":"[libcamera-devel,v1,04/23] gst: utils: Add a macro to use a GMutexLocker","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c48f20527f190b3d7b6c73b6241685a4195dfd1a","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/1.1/people/30/?format=json","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2738/mbox/","series":[{"id":648,"url":"https://patchwork.libcamera.org/api/1.1/series/648/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=648","date":"2020-01-29T03:31:47","name":"GStreamer Element for libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/648/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2738/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2738/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 401D5608BF\n\tfor ;\n\tWed, 29 Jan 2020 04:35:20 +0100 (CET)","from nicolas-tpx395.localdomain (unknown\n\t[IPv6:2002:c0de:c115:0:66fc:8b:2a38:8313])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 79D9E28EA9F;\n\tWed, 29 Jan 2020 03:35:19 +0000 (GMT)"],"From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ","Date":"Tue, 28 Jan 2020 22:31:51 -0500","Message-Id":"<20200129033210.278800-5-nicolas@ndufresne.ca>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200129033210.278800-1-nicolas@ndufresne.ca>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 04/23] gst: utils: Add a macro to use a\n\tGMutexLocker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 Jan 2020 03:35:20 -0000"},"content":"From: Nicolas Dufresne \n\nThe GMutexLocker uses GCC/CLANG C feature to implement a smart lock,\nthat unlocks the mutex when the GMutexLocker goes out of scope. This\ncould have been implemented in C++, but as this is already implemented\nI decided to just reuse it. This is particularly handy to avoid gotos\nin error handling cases and to prevent unbalanced locking.\n\nSigned-off-by: Nicolas Dufresne \n---\n src/gstreamer/gstlibcamera-utils.h | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\nindex 4545512..528dc2c 100644\n--- a/src/gstreamer/gstlibcamera-utils.h\n+++ b/src/gstreamer/gstlibcamera-utils.h\n@@ -13,6 +13,8 @@\n \n #ifndef __GST_LIBCAMERA_UTILS_H_\n \n+#define GST_OBJECT_LOCKER(obj) g_autoptr(GMutexLocker) locker = g_mutex_locker_new(GST_OBJECT_GET_LOCK(obj))\n+\n GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &formats);\n \n #endif /* __GST_LIBCAMERA_UTILS_H_ */\n","prefixes":["libcamera-devel","v1","04/23"]}