{"id":27339,"url":"https://patchwork.libcamera.org/api/1.1/patches/27339/?format=json","web_url":"https://patchwork.libcamera.org/patch/27339/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260708-libipa-algorithms-v5-31-0759d0359f52@ideasonboard.com>","date":"2026-07-08T15:51:13","name":"[v5,31/36] ipa: libipa: lsc_base: Describe the function of lsc_base","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"560ece815ff4611f5c72042e0eae5192cafc290a","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27339/mbox/","series":[{"id":6048,"url":"https://patchwork.libcamera.org/api/1.1/series/6048/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6048","date":"2026-07-08T15:50:42","name":"ipa: libipa: Introduce libipa algorithms","version":5,"mbox":"https://patchwork.libcamera.org/series/6048/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27339/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27339/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75874C3261\n\tfor ;\n\tWed, 8 Jul 2026 15:51:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08ABF66122;\n\tWed, 8 Jul 2026 17:51:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D1CC660E1\n\tfor ;\n\tWed, 8 Jul 2026 17:51:22 +0200 (CEST)","from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 421631CFD;\n\tWed, 8 Jul 2026 17:50:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"S+VrK6z4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783525832;\n\tbh=2QvgZUzLDc2ja7R9EkinL3mS8x7xRAxO+EYGjrc7vbU=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=S+VrK6z4YVDphyIYq2CWnXaMiHTihyYEszSCyYsxOWamk4+IfYO3VLhGaw/mM119Z\n\te7gkUjyrVLi19QKcbIc9YWpg9FGjP+4qF+e4CnBBt1TJNx5X9eNtowtoRhrqoDhuX4\n\tRx5umKxt88B4VXo9uKfxO7QRNcLkwiPeGwn0aTX8=","From":"Jacopo Mondi ","Date":"Wed, 08 Jul 2026 17:51:13 +0200","Subject":"[PATCH v5 31/36] ipa: libipa: lsc_base: Describe the function of\n\tlsc_base","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260708-libipa-algorithms-v5-31-0759d0359f52@ideasonboard.com>","References":"<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>","In-Reply-To":"<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug ","Cc":"Jacopo Mondi ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1646;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=2QvgZUzLDc2ja7R9EkinL3mS8x7xRAxO+EYGjrc7vbU=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqTnHsY+ooRauRg5kUkwAZcxTRbA5sBc5cQPShj\n\tZdkGUdHeUqJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak5x7AAKCRByNAaPFqFW\n\tPLdFEACBfSt1warTMjInwgyM7KrOxIIyqlLYwFbKDUTKgQyB26bQsS6Cg49ylntEc3pSV18/c5t\n\tlFdl4NS04LrMf/lwkIV1ExNtmlz7bOcecaM7kUvo9diXaP5JPKr9vdyJKtuPdElIfTjkTj5GPWo\n\tbgTBKhlfMJ8wh41CchxNnvPfCgkAhvnSiU6ORTbZhGd8nJHAsdlSrpEKP73cYsHDHUNEplOJCtZ\n\tvVhO4i+lS2uq56qK3dlyeJMrWOE2g1iSlUuQkovX+nT67ZY67MQBT4BZpEOOb3tAva8BgBDgDVM\n\tgwuPqeRJHKOLpH2klWuhLtlTQl5T1tcz1vYCDfIrAWZApixYViTMA7mg7ymf32dd9EhbX1PqMnW\n\tvyc7iabwfQRtNSQTM9Etix/7FW2ax6cXxEHW/j8fPu+88DlcXGLQXIC/Ic95DgwjxsCOzNpP6As\n\tUvb1bWC3/mlUpbCbtGn3Tyx3wPTxh85vV2HKZBHV+e/vgUS7rYcgAlkpeu3JhdgiJpqCGbNo87k\n\tUwGXgu9ycScVi9K7+/KnWCa2n9xqewfiqgyv0IKSE9i/R7g8N6MIwgTvGibfShkFe9CoZ+mecZC\n\tiI1eVVkV8R2AfzZPIsOpftfJr/xbX6e9qyj4b7UVT59x3xw1VmN2Owpp19zRrxxqPGgFrYxig1V\n\tS0u4L7AicB9LFkw==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that the class hierarchy is in place, describe the function\nof the lsc_base header in the file comment.\n\nSigned-off-by: Jacopo Mondi \n---\n src/ipa/libipa/lsc_base.cpp | 16 +++++++++++++++-\n 1 file changed, 15 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex b91da4e5be9d..dd2e1128a546 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -10,6 +10,19 @@\n /**\n * \\file lsc_base.h\n * \\brief Base types and definitions for LscImplementation class hierarchy\n+ *\n+ * Split the common classes and types definitions to a dedicated file to avoid\n+ * circular inclusions.\n+ *\n+ * Both LscTable and LscPolynomial inherit from LscImplementation and they are\n+ * instantiated from lsc.h as the LscAlgorithm::init() function is there inlined.\n+ *\n+ * For this reason lsc.h needs to include lsc_table.h and lsc_polynomial.h which\n+ * need the LscImplementation class definition themselves.\n+ *\n+ * Split the LscImplementation interface definition to this file so that it can\n+ * be included by both lsc_table.h and lsc_polynomial.h, which are then included\n+ * by lsc.h.\n */\n \n namespace libcamera {\n@@ -88,7 +101,8 @@ void Interpolator::\n * \\brief Pure virtual base class for LSC algorithm implementations\n * \\tparam U The fixedpoint LSC engine register format\n *\n- * Defines the interface for the LSC algorithm implementation.\n+ * Defines the interface for the LSC algorithm implementation. Currently\n+ * implemented by LscTable and LscPolynomial.\n */\n \n /**\n","prefixes":["v5","31/36"]}